New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds commonly used `cargo make` tasks #621

Merged
merged 2 commits into from Jan 9, 2019

Conversation

Projects
None yet
5 participants
@D4nte
Copy link
Member

D4nte commented Jan 7, 2019

As per feedback in #613, added more details on how to run tests.
Also explains the labels related to issues for wanna-be contributors


  • RTM (Ready To Merge)

@wafflebot wafflebot bot assigned D4nte Jan 7, 2019

@wafflebot wafflebot bot added the review label Jan 7, 2019

@D4nte D4nte requested a review from comit-network/rust-devs Jan 7, 2019

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Jan 7, 2019

CLA assistant check
All committers have signed the CLA.

## Fixing an issue

If you wish to pick up an existing issue and resolve it, please be aware of the following labels:
- ✅ [`groomed`](https://github.com/comit-network/comit-rs/labels/groomed): it has been discussed and should contain enough details to get started

This comment has been minimized.

@LLFourn

LLFourn Jan 7, 2019

Contributor

Are these emojis helpful? How are the labels associated with them?

This comment has been minimized.

@D4nte

D4nte Jan 7, 2019

Author Member

It means "yes, you can pick up issues labelled with X" "no, you should not pick up issues labelled with Y".

Happy to remove if it's confusing.

This comment has been minimized.

@luckysori

luckysori Jan 7, 2019

Contributor

I like the emojis.

@D4nte D4nte added this to the Sprint 4 🎄🎅🏿 milestone Jan 7, 2019

@D4nte D4nte requested a review from comit-network/rust-devs Jan 7, 2019

- 🤔 [Unlabelled](https://github.com/comit-network/comit-rs/issues?q=is%3Aopen+no%3Alabel): it has not yet been reviewed for design, please avoid
- 🛑 [`icebox`](https://github.com/comit-network/comit-rs/labels/icebox): it is not the right time to proceed with this issue, please do not pick it
- 🛑 [`sprint-backlog`](https://github.com/comit-network/comit-rs/labels/sprint-backlog): it will be picked up in our next sprint, please do not pick it
- 🛑 [`candidate-contribution`](https://github.com/comit-network/comit-rs/labels/candidate-contribution): it has been specially groomed to be used as part of our hiring process, please do not pick it

This comment has been minimized.

@luckysori

luckysori Jan 7, 2019

Contributor

Should we include a link to wherever people can apply for a job?

This comment has been minimized.

@D4nte

D4nte Jan 7, 2019

Author Member

I like the idea!

## Fixing an issue

If you wish to pick up an existing issue and resolve it, please be aware of the following labels:
- ✅ [`groomed`](https://github.com/comit-network/comit-rs/labels/groomed): it has been discussed and should contain enough details to get started

This comment has been minimized.

@luckysori

luckysori Jan 7, 2019

Contributor

I like the emojis.

@D4nte D4nte requested a review from comit-network/rust-devs Jan 8, 2019

@LLFourn

LLFourn approved these changes Jan 8, 2019

Copy link
Contributor

LLFourn left a comment

Remove confusing emoji please.

- [Unlabelled](https://github.com/comit-network/comit-rs/issues?q=is%3Aopen+no%3Alabel): it has not yet been reviewed for design, please avoid
- [`icebox`](https://github.com/comit-network/comit-rs/labels/icebox): it is not the right time to proceed with this issue, please do not pick it
- [`sprint-backlog`](https://github.com/comit-network/comit-rs/labels/sprint-backlog): it will be picked up in our next sprint, please do not pick it
- [`candidate-contribution`](https://github.com/comit-network/comit-rs/labels/candidate-contribution): it has been groomed to be used as part of our hiring process, please do not pick it; [keen to join?](https://tenx.workable.com/jobs/689268)

This comment has been minimized.

@bonomat

bonomat Jan 8, 2019

Member

🤡What do you think of ordering the labels differently? I would propose:

  • Unlabelled
  • icebox
  • groomed
  • candidate-contribution
  • sprint-backlog

i.e. first the labels we don't want someone to take.
Also, should we add: good first issue ?

This comment has been minimized.

@D4nte

D4nte Jan 8, 2019

Author Member

So I actually hesitated to add a line about good-first-issue but I thought the label is actually very explicit in itself so no need to over explain.

This comment has been minimized.

@D4nte

D4nte Jan 8, 2019

Author Member

Well, actually we want people to only pick up groomed, right?

- [Unlabelled](https://github.com/comit-network/comit-rs/issues?q=is%3Aopen+no%3Alabel): it has not yet been reviewed for design, please avoid
- [`icebox`](https://github.com/comit-network/comit-rs/labels/icebox): it is not the right time to proceed with this issue, please do not pick it
- [`sprint-backlog`](https://github.com/comit-network/comit-rs/labels/sprint-backlog): it will be picked up in our next sprint, please do not pick it
- [`candidate-contribution`](https://github.com/comit-network/comit-rs/labels/candidate-contribution): it has been groomed to be used as part of our hiring process, please do not pick it; [keen to join?](https://tenx.workable.com/jobs/689268)

This comment has been minimized.

@bonomat

bonomat Jan 8, 2019

Member
Suggested change Beta
- [`candidate-contribution`](https://github.com/comit-network/comit-rs/labels/candidate-contribution): it has been groomed to be used as part of our hiring process, please do not pick it; [keen to join?](https://tenx.workable.com/jobs/689268)
- [`candidate-contribution`](https://github.com/comit-network/comit-rs/labels/candidate-contribution): it has been groomed to be used as part of our hiring process [keen to join?](https://tenx.workable.com/jobs/689268)

I think we should be happy for any contribution and we should not stop someone from doing tickets :)

This comment has been minimized.

@D4nte

D4nte Jan 8, 2019

Author Member

ok are you thinking the same about sprint-backlog then?

@bonomat
Copy link
Member

bonomat left a comment

Added some comments

@D4nte D4nte force-pushed the readme branch 2 times, most recently from acbf8f7 to 6f4a810 Jan 9, 2019

@bonomat

bonomat approved these changes Jan 9, 2019

@D4nte D4nte force-pushed the readme branch from 6f4a810 to 227f1e1 Jan 9, 2019

@mergify mergify bot merged commit e2797e9 into master Jan 9, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details

@mergify mergify bot deleted the readme branch Jan 9, 2019

@wafflebot wafflebot bot removed the review label Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment