New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement PR for #616 #648

Merged
merged 3 commits into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@thomaseizinger
Copy link
Member

thomaseizinger commented Jan 15, 2019

This PR supersedes #616.

It seems that something went wrong in the initial commit of #616 which includes many, unrelated changes. I've picked the relevant ones and created a new PR here that only contains those but attributes the changes back to @its-me-yours-truly.

thomaseizinger and others added some commits Jan 15, 2019

Tilde was not shell escaped in config parser
Co-authored-by: Dr D Cagara <noreply@cagara.de>
@D4nte

D4nte approved these changes Jan 16, 2019

@thomaseizinger thomaseizinger force-pushed the its-me-yours-truly-pr branch from 633e860 to 1d4b473 Jan 16, 2019

@mergify mergify bot merged commit 0ca4cc8 into master Jan 16, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot removed the review label Jan 16, 2019

@mergify mergify bot deleted the its-me-yours-truly-pr branch Jan 16, 2019

@D4nte D4nte added this to the Sprint 6 🔄📖 milestone Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment