Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve TODO #750

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@thomaseizinger
Copy link
Member

thomaseizinger commented Feb 11, 2019

As per RFC1, responses that fail to deserialize should simply be logged.

This is a follow-up to merging comit-network/RFCs#29

@thomaseizinger thomaseizinger requested a review from comit-network/rust-devs Feb 11, 2019

@wafflebot wafflebot bot added the review label Feb 11, 2019

@thomaseizinger thomaseizinger force-pushed the resolve-todo-deserialize branch 3 times, most recently from c6d72b6 to 582d6f9 Feb 11, 2019

@D4nte

D4nte approved these changes Feb 12, 2019

Resolve TODO
As per RFC1, responses that fail to deserialize should simply be
logged.

@D4nte D4nte force-pushed the resolve-todo-deserialize branch from 582d6f9 to eacd43d Feb 13, 2019

@mergify mergify bot merged commit 1c9f2ce into master Feb 13, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details

@mergify mergify bot deleted the resolve-todo-deserialize branch Feb 13, 2019

@wafflebot wafflebot bot removed the review label Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.