Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clarity instead of emerald-rs #286

Merged
merged 1 commit into from Dec 30, 2019
Merged

Use clarity instead of emerald-rs #286

merged 1 commit into from Dec 30, 2019

Conversation

@thomaseizinger
Copy link
Member

thomaseizinger commented Dec 13, 2019

Clarity is a low-level library for Ethereum that implements all the necessary transaction signing for us! <3

Fixes #110.

@thomaseizinger thomaseizinger requested review from D4nte and luckysori Dec 13, 2019
@thomaseizinger thomaseizinger self-assigned this Dec 13, 2019
@mergify

This comment has been minimized.

Copy link
Contributor

mergify bot commented Dec 13, 2019

Are you sure the changelog does not need updating?

1 similar comment
@mergify

This comment has been minimized.

Copy link
Contributor

mergify bot commented Dec 16, 2019

Are you sure the changelog does not need updating?

@bonomat bonomat force-pushed the use-clarity branch from d661997 to 54fb03d Dec 17, 2019
Clarity is a low-level library for Ethereum that implements
all the necessary transaction signing for us! <3
@thomaseizinger thomaseizinger force-pushed the use-clarity branch from e797240 to afd20f8 Dec 30, 2019
@D4nte
D4nte approved these changes Dec 30, 2019
@@ -71,7 +71,7 @@ pub async fn execute(terminate: Arc<AtomicBool>) -> anyhow::Result<Environment>
);
envfile.update(
"ERC20_CONTRACT_ADDRESS",
&format!("0x{:x}", parity.erc20_contract_address),
&format!("{:#x}", parity.erc20_contract_address),

This comment has been minimized.

Copy link
@D4nte

D4nte Dec 30, 2019

Member

Do we have a test for that?

This comment has been minimized.

Copy link
@thomaseizinger

thomaseizinger Dec 30, 2019

Author Member

Not yet but there is a ticket: #94

@mergify

This comment has been minimized.

Copy link
Contributor

mergify bot commented Dec 30, 2019

bors r+

1 similar comment
@mergify

This comment has been minimized.

Copy link
Contributor

mergify bot commented Dec 30, 2019

bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Dec 30, 2019

Already running a review

bors bot added a commit that referenced this pull request Dec 30, 2019
Merge #286
286: Use clarity instead of emerald-rs r=mergify[bot] a=thomaseizinger

Clarity is a low-level library for Ethereum that implements all the necessary transaction signing for us! <3

Fixes #110.

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Dec 30, 2019

Build succeeded

  • build (macos)
  • build (ubuntu)
  • build (windows)
  • e2e_test
  • static_analysis
@bors bors bot merged commit afd20f8 into master Dec 30, 2019
9 checks passed
9 checks passed
static_analysis
Details
build (macos)
Details
build (windows)
Details
build (ubuntu)
Details
npm_build
Details
e2e_test
Details
Summary 3 rules match
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@mergify mergify bot deleted the use-clarity branch Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.