Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spike for LN as alpha ledger #6

Merged
merged 23 commits into from May 3, 2019

Conversation

Projects
None yet
4 participants
@bonomat
Copy link
Member

commented Apr 24, 2019

Spike for supporting Lightning Network as Alpha Ledger.

Resolves comit-network/comit-rs#841

@ghost ghost assigned bonomat Apr 24, 2019

@ghost ghost added the review label Apr 24, 2019

bonomat added some commits Apr 24, 2019

Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated

bonomat added some commits Apr 25, 2019

Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.md Outdated

D4nte and others added some commits Apr 26, 2019

Update 0003-lightning-as-alpha-ledger.md
Co-Authored-By: bonomat <philipp@hoenisch.at>
@D4nte

D4nte approved these changes Apr 29, 2019

Copy link
Member

left a comment

Great and exciting stuff!

@bonomat bonomat referenced this pull request Apr 29, 2019

Closed

Use asciiDoc instead of markdown #61

3 of 3 tasks complete

bonomat added some commits Apr 29, 2019

Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc Outdated
@D4nte

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@thomaseizinger you have quite a lot of comments that I don't think were in the original spike you wrote with @LLFourn. Is there any notes or discussions that you had that were not reported in the original spike?

@thomaseizinger

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@thomaseizinger you have quite a lot of comments that I don't think were in the original spike you wrote with @LLFourn. Is there any notes or discussions that you had that were not reported in the original spike?

We never wrote a spike, we only started looking into the topic for ~1h. There were quite a few unanswered questions and open points at that point. All we wrote down was the current state, which was mostly about getting the new feature to actually work + what you can do with it.
I am bit surprised about your expectation that our spike was done/complete.

Some of the open points have now been answered/addressed in this spike, hence my comments.

Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc
@D4nte

This comment has been minimized.

Copy link
Member

commented May 2, 2019

@thomaseizinger you have quite a lot of comments that I don't think were in the original spike you wrote with @LLFourn. Is there any notes or discussions that you had that were not reported in the original spike?

We never wrote a spike, we only started looking into the topic for ~1h. There were quite a few unanswered questions and open points at that point. All we wrote down was the current state, which was mostly about getting the new feature to actually work + what you can do with it.
I am bit surprised about your expectation that our spike was done/complete.

Some of the open points have now been answered/addressed in this spike, hence my comments.

Clearly a misunderstanding. I thought the take over was to organise the work to be done. I understood that the spike was finished hence my surprise of the initial content length. Now I wonder why it was handed over. Clearly I missed something🤔

@thomaseizinger

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Clearly a misunderstanding. I thought the take over was to organise the work to be done. I understood that the spike was finished hence my surprise of the initial content length. Now I wonder why it was handed over. Clearly I missed something 🤔

IIRC it was handed over because I started to work on libp2p stuff and @LLFourn started to dig into Scriptless-Scripts.
This happened as a result of discussing, who is the most interested in working on which topics. I think you and @bonomat were keen on Lightning, hence you took over were we left of.

@D4nte

This comment has been minimized.

Copy link
Member

commented May 2, 2019

I see no pending comments, is this ready for merge?

Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc Outdated
Show resolved Hide resolved 0003-lightning-as-alpha-ledger.adoc

bonomat added some commits May 3, 2019

bonomat added some commits May 3, 2019

v2
v3

@bonomat bonomat merged commit 478a823 into master May 3, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details

@bonomat bonomat removed the review label May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.