Skip to content

CANParser: auto-detect frequency - #2527

Merged
adeebshihadeh merged 17 commits into
masterfrom
auto-freq
Jul 23, 2025
Merged

CANParser: auto-detect frequency#2527
adeebshihadeh merged 17 commits into
masterfrom
auto-freq

Conversation

@adeebshihadeh

@adeebshihadeh adeebshihadeh commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Our frequency checks are currently relatively lax. While it would be nice (in theory) to make them stricter, I can't recall an issue the extra strictness would have caught.

And this lets us ship a significant red diff (#2521) to car ports.


A sample from running test_models on this branch:

0x444 TRACK_14 got 21.00Hz, old 500.00 new 476.20
0x445 TRACK_15 got 21.00Hz, old 500.00 new 476.20
0x156 STEERING_SENSORS got 100.00Hz, old 100.00 new 100.00
0x1A4 VSA_STATUS got 50.99Hz, old 200.00 new 196.10
0x1B0 STANDSTILL got 50.99Hz, old 200.00 new 196.10
0x158 ENGINE_DATA got 100.00Hz, old 100.00 new 100.00
0x17C POWERTRAIN_DATA got 100.00Hz, old 100.00 new 100.00
0x188 GEARBOX_AUTO got 100.00Hz, old 200.00 new 100.00
0x1D0 WHEEL_SPEEDS got 50.99Hz, old 200.00 new 196.10
0x18F STEER_STATUS got 100.00Hz, old 100.00 new 100.00
0x194 STEERING_CONTROL got 100.00Hz, old 100.00 new 100.00
0x1FA BRAKE_COMMAND got 50.99Hz, old 200.00 new 196.10
0x1A6 SCM_BUTTONS got 50.99Hz, old 400.00 new 196.10
0x324 CRUISE got 11.00Hz, old 1000.00 new 909.15
0x294 SCM_FEEDBACK got 25.74Hz, old 1000.00 new 388.50
0x30C ACC_HUD got 11.00Hz, old 1000.00 new 909.21
0x33D LKAS_HUD got 11.00Hz, old 1000.00 new 909.21
0x305 SEATBELT_STATUS got 11.00Hz, old 1000.00 new 909.21
0x309 CAR_SPEED got 10.89Hz, old 1000.00 new 918.22

@github-actions github-actions Bot added the can related to CAN tools, aka opendbc/can/ label Jul 22, 2025
Comment thread opendbc/can/parser.cc Outdated
@adeebshihadeh
adeebshihadeh merged commit 7ff7798 into master Jul 23, 2025
5 checks passed
@adeebshihadeh
adeebshihadeh deleted the auto-freq branch July 23, 2025 03:09
FeistyFinn pushed a commit to FeistyFinn/opendbc that referenced this pull request Jun 25, 2026
* noop first

* move valid

* flatten

* update cython

* counters aren't special

* counter is special... for now

* fix mac

* works pretty well

* fix 1khz radar

* handle timeout

* cleanup

* ignore alive for the bolt

* lil simpler

* revert that

* Blinkmodi_02 special sauce

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can related to CAN tools, aka opendbc/can/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants