From 57f5ef8cd80d09853262895fcf9ab5ce592345e0 Mon Sep 17 00:00:00 2001 From: Riccardo Date: Mon, 18 Nov 2019 15:53:08 -0800 Subject: [PATCH] Fix misra: addr can't be more than 29 bits anyway --- board/safety/safety_elm327.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/safety/safety_elm327.h b/board/safety/safety_elm327.h index e5ac049500b6dc..df515b05d6ad8f 100644 --- a/board/safety/safety_elm327.h +++ b/board/safety/safety_elm327.h @@ -11,8 +11,8 @@ static int elm327_tx_hook(CAN_FIFOMailBox_TypeDef *to_send) { //Check valid 29 bit send addresses for ISO 15765-4 //Check valid 11 bit send addresses for ISO 15765-4 - if ((addr != 0x18DB33F1) && ((addr & 0xFFFF00FF) != 0x18DA00F1) && - ((addr != 0x7DF) && ((addr & 0xFFFFFFF8) != 0x7E0))) { + if ((addr != 0x18DB33F1) && ((addr & 0x1FFF00FF) != 0x18DA00F1) && + ((addr != 0x7DF) && ((addr & 0x1FFFFFF8) != 0x7E0))) { tx = 0; } return tx;