Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmonitoringd #1016

Merged
merged 21 commits into from Jan 31, 2020
Merged

dmonitoringd #1016

merged 21 commits into from Jan 31, 2020

Conversation

@ZwX1616
Copy link
Contributor

ZwX1616 commented Jan 28, 2020

  • DM is no longer a part of controlsd
  • reduce wheel touch timeout to 1min
  • improve model as in 0.7.2 description
ZwX1616 added 2 commits Jan 28, 2020
rk
ZwX1616 added 10 commits Jan 28, 2020
selfdrive/controls/controlsd.py Outdated Show resolved Hide resolved
selfdrive/controls/monitord.py Outdated Show resolved Hide resolved
selfdrive/controls/monitord.py Outdated Show resolved Hide resolved
selfdrive/controls/monitord.py Outdated Show resolved Hide resolved
selfdrive/controls/controlsd.py Outdated Show resolved Hide resolved
selfdrive/controls/monitord.py Outdated Show resolved Hide resolved
selfdrive/controls/monitord.py Outdated Show resolved Hide resolved
selfdrive/controls/monitord.py Outdated Show resolved Hide resolved
ZwX1616 added 4 commits Jan 29, 2020
selfdrive/controls/monitord.py Outdated Show resolved Hide resolved
@pd0wm

This comment has been minimized.

Copy link
Contributor

pd0wm commented Jan 29, 2020

Did you see any change to cpu usage after the refactor? Interested in controlsd usage before and after this change.

@ZwX1616

This comment has been minimized.

Copy link
Contributor Author

ZwX1616 commented Jan 29, 2020

Did you see any change to cpu usage after the refactor? Interested in controlsd usage before and after this change.

will do another test drive today. we shall see

@ZwX1616

This comment has been minimized.

Copy link
Contributor Author

ZwX1616 commented Jan 29, 2020

Did you see any change to cpu usage after the refactor? Interested in controlsd usage before and after this change.

controlsd: ~51% at normal cruise, ~56% with distraction event;
monitord: 5.3%-5.6% at all times

@pd0wm

This comment has been minimized.

Copy link
Contributor

pd0wm commented Jan 30, 2020

How much was controlsd before the change?

@pd0wm

This comment has been minimized.

Copy link
Contributor

pd0wm commented Jan 30, 2020

Can you rebase to latest master and make sure the release build also works? You probably need to add selfdrive/controlsd/monitoringd.py to release/files_common.

Do you want this to ship with 0.7.2?

@ZwX1616

This comment has been minimized.

Copy link
Contributor Author

ZwX1616 commented Jan 30, 2020

How much was controlsd before the change?

around 60%

@ZwX1616

This comment has been minimized.

Copy link
Contributor Author

ZwX1616 commented Jan 30, 2020

Can you rebase to latest master and make sure the release build also works? You probably need to add selfdrive/controlsd/monitoringd.py to release/files_common.

Do you want this to ship with 0.7.2?

Yes and yes. The added log struct will be super useful for future troubleshooting.
Adding the file now...

@pd0wm pd0wm added this to the 0.7.2 milestone Jan 30, 2020
ZwX1616 added 4 commits Jan 30, 2020
@ZwX1616 ZwX1616 changed the title monitord dmonitoringd Jan 31, 2020
@ZwX1616 ZwX1616 merged commit 6322a27 into master Jan 31, 2020
13 checks passed
13 checks passed
build
Details
build
Details
linter
Details
linter
Details
unit tests
Details
unit tests
Details
process replay
Details
process replay
Details
longitudinal
Details
longitudinal
Details
test car models
Details
test car models
Details
continuous-integration/jenkins/branch This commit looks good
Details
@pd0wm pd0wm deleted the monitord branch Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.