Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test car models: fix random hanging #1055

Merged
merged 5 commits into from Feb 6, 2020
Merged

test car models: fix random hanging #1055

merged 5 commits into from Feb 6, 2020

Conversation

@quillford
Copy link
Contributor

quillford commented Feb 5, 2020

Running locally, I reproduced a similar failure to the one seen in CI recently. It would get stuck downloading the front camera video, which was unnecessary, and was probably only done to make unlogger happy. Not having to download those videos each time should speed up the test a bit. Also added a timeout to the request so it doesn't just wait forever.

Fixes #1043

@quillford quillford changed the title test car models test car models: fix random hanging Feb 5, 2020
@pd0wm

This comment has been minimized.

Copy link
Contributor

pd0wm commented Feb 6, 2020

Nice! This should also significantly cut down on bandwidth cost to our openpilotci bucket :)

@pd0wm pd0wm merged commit 30dffb4 into commaai:master Feb 6, 2020
6 checks passed
6 checks passed
build
Details
linter
Details
unit tests
Details
process replay
Details
longitudinal
Details
test car models
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.