Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lexus RC support #22941

Merged
merged 8 commits into from Nov 22, 2021
Merged

Add Lexus RC support #22941

merged 8 commits into from Nov 22, 2021

Conversation

ErichMoraga
Copy link
Contributor

@ErichMoraga ErichMoraga commented Nov 17, 2021

@ph33rl355#529 2020 Lexus RC F Track Edition DongleID/route 32696cea52831b02|2021-11-16--23-12-02

Doesn't seem to need a full port, per user feedback...
https://discord.com/channels/469524606043160576/524327905937850394/910400788319326229

ErichMoraga added a commit to ErichMoraga/openpilot that referenced this pull request Nov 18, 2021
This catches things up to my latest PR...
commaai#22941
ErichMoraga added a commit to ErichMoraga/openpilot that referenced this pull request Nov 18, 2021
This catches things up to my latest PR...
commaai#22941
ErichMoraga added a commit to ErichMoraga/openpilot that referenced this pull request Nov 18, 2021
This catches things up to my latest PR...
commaai#22941
ErichMoraga added a commit to ErichMoraga/openpilot that referenced this pull request Nov 18, 2021
This catches things up to my latest PR...
commaai#22941
ErichMoraga added a commit to ErichMoraga/openpilot that referenced this pull request Nov 18, 2021
This catches things up to my latest PR...
commaai#22941
@pd0wm
Copy link
Contributor

pd0wm commented Nov 18, 2021

Any specific reason to move this under the IS? Is it based off the same car?

The FW versions seems to have a distinct prefix of 24 vs 53 for the IS

@ErichMoraga
Copy link
Contributor Author

ErichMoraga commented Nov 19, 2021

Any specific reason to move this under the IS? Is it based off the same car?

The FW versions seems to have a distinct prefix of 24 vs 53 for the IS

The RC was moved under the IS mostly out of simplicity, as the cars are extremely similar... part of the Lexus sports car line-up. Furthermore, the RC seems to drive fine, with only some slight ping pong... typical for a pre-LSS2 car. Lastly, this will possibly be the only RC running OP.

Created an 'rc' branch in my openpilot repo. for testing, just in case...
ErichMoraga@3793031

@pd0wm
Copy link
Contributor

pd0wm commented Nov 19, 2021

Let's split it out in a new car, but you can reuse the IS dbc.

@ErichMoraga
Copy link
Contributor Author

Let's split it out in a new car, but you can reuse the IS dbc.

DONE.

Copy link
Contributor Author

@ErichMoraga ErichMoraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimum speed might actually be closer to 25, but the user doesn't seem sure...
https://discord.com/channels/469524606043160576/524327905937850394/910963149329563778

@ErichMoraga ErichMoraga changed the title Add f/w firmware for Lexus RC under LEXUS_IS Add f/w firmware for Lexus RC using LEXUS_IS DBC Nov 19, 2021
@ErichMoraga ErichMoraga changed the title Add f/w firmware for Lexus RC using LEXUS_IS DBC Add Lexus RC support Nov 19, 2021
@pd0wm
Copy link
Contributor

pd0wm commented Nov 19, 2021

Do you have a test route?

Does it also use the alternate cancel message like the IS?

ErichMoraga and others added 4 commits November 19, 2021 17:22
@ErichMoraga
Copy link
Contributor Author

ErichMoraga commented Nov 19, 2021

32696cea52831b02|2021-11-19--09-07-37 is his latest drive (he's been driving a few days with the f/w hacked into values.py). I see you made some good updates. I'm SSH'd into his C3 now, and will patch his C3 accordingly.

No idea about the alternate cancel message.

@ErichMoraga
Copy link
Contributor Author

ErichMoraga commented Nov 19, 2021

Thanks for your help @pd0wm (I have a lot of distractions). I've manually loaded the user's C3 w/ all the changes via wget (DL'd raw files onto his device), and manually compiled. Rebooted his C3, so next time he drives, that route will have changes identical to what's in this PR ;-)

Once a fresh route is available, I'll add it to selfdrive/test/test_routes.py

I'm hesitant to touch `mass`, even though I know it's different from the IS.
@ErichMoraga
Copy link
Contributor Author

Do you have a test route?

Added test route... 32696cea52831b02|2021-11-19--18-13-30

@adeebshihadeh
Copy link
Contributor

The route doesn't have rlogs uploaded. I just requested them, but the user should keep their device on wifi until it's fully uploaded.

@ErichMoraga
Copy link
Contributor Author

ErichMoraga commented Nov 20, 2021

The route doesn't have rlogs uploaded. I just requested them, but the user should keep their device on wifi until it's fully uploaded.

All 38 rlogs for that route just finished uploading.

@adeebshihadeh
Copy link
Contributor

This looks very similar to the quirky IS. Also looks like the IS cancel works in the test route.

@adeebshihadeh adeebshihadeh merged commit d630ec9 into commaai:master Nov 22, 2021
@ErichMoraga ErichMoraga deleted the patch-1 branch November 23, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants