New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lexus RC support #22941
Add Lexus RC support #22941
Conversation
This catches things up to my latest PR... commaai#22941
This catches things up to my latest PR... commaai#22941
This catches things up to my latest PR... commaai#22941
This catches things up to my latest PR... commaai#22941
This catches things up to my latest PR... commaai#22941
Any specific reason to move this under the IS? Is it based off the same car? The FW versions seems to have a distinct prefix of |
The RC was moved under the IS mostly out of simplicity, as the cars are extremely similar... part of the Lexus sports car line-up. Furthermore, the RC seems to drive fine, with only some slight ping pong... typical for a pre-LSS2 car. Lastly, this will possibly be the only RC running OP. Created an 'rc' branch in my openpilot repo. for testing, just in case... |
Let's split it out in a new car, but you can reuse the IS dbc. |
DONE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimum speed might actually be closer to 25, but the user doesn't seem sure...
https://discord.com/channels/469524606043160576/524327905937850394/910963149329563778
Do you have a test route? Does it also use the alternate cancel message like the IS? |
`@ph33rl355#0529` 2020 Lexus RC F Track Edition DongleID/route 32696cea52831b02|2021-11-16--23-12-02 Doesn't seem to need a full port, per user feedback... https://discord.com/channels/469524606043160576/524327905937850394/910400788319326229
32696cea52831b02|2021-11-19--09-07-37 is his latest drive (he's been driving a few days with the f/w hacked into No idea about the alternate cancel message. |
Thanks for your help @pd0wm (I have a lot of distractions). I've manually loaded the user's C3 w/ all the changes via wget (DL'd raw files onto his device), and manually compiled. Rebooted his C3, so next time he drives, that route will have changes identical to what's in this PR ;-) Once a fresh route is available, I'll add it to |
I'm hesitant to touch `mass`, even though I know it's different from the IS.
Added test route... |
The route doesn't have rlogs uploaded. I just requested them, but the user should keep their device on wifi until it's fully uploaded. |
All 38 rlogs for that route just finished uploading. |
This looks very similar to the quirky IS. Also looks like the IS cancel works in the test route. |
@ph33rl355#529
2020 Lexus RC F Track Edition DongleID/route 32696cea52831b02|2021-11-16--23-12-02Doesn't seem to need a full port, per user feedback...
https://discord.com/channels/469524606043160576/524327905937850394/910400788319326229