New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Toyota Highlander (+Hybrid) support #341

Closed
wants to merge 11 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@daehahn
Copy link
Contributor

daehahn commented Aug 30, 2018

Working on 2017 Highlander and 2018 Highlander Hybrid. It's basically working, but definitely need a lot of turning.

daehahn added some commits Aug 21, 2018

Add support for Toyota Highlander Hybrid
Copied from "toyota_rav4_hybrid_2017_pt_generated.dbc"
Add support for Toyota Highlander Hybrid
Copied from "toyota_rav4_hybrid_2017_pt.dbc"

daehahn added some commits Aug 31, 2018

Update for Highlander.
Since we just tested on Highlander 2017 and Hybrid 2018.
Show resolved Hide resolved README.md Outdated

(0x32E, ECU.APGS, (CAR.PRIUS, CAR.RAV4H, CAR.LEXUS_RXH, CAR.RAV4, CAR.COROLLA, CAR.HIGHLANDERH, CAR.HIGHLANDER), 0, 20, '\x00\x00\x00\x00\x00\x00\x00\x00'),
(0x33E, ECU.DSU, (CAR.PRIUS, CAR.RAV4H, CAR.LEXUS_RXH, CAR.HIGHLANDERH), 0, 20, '\x0f\xff\x26\x40\x00\x1f\x00'),
(0x344, ECU.DSU, (CAR.HIGHLANDERH, CAR.HIGHLANDER), 0, 20, '\x00\x00\x01\x00\x00\x00\x00\x50'),

This comment has been minimized.

@rbiasini

rbiasini Sep 3, 2018

Contributor

this is the same as 0x344 defined in line 37, except for the frequency. You sure about it?

This comment has been minimized.

@daehahn

daehahn Sep 3, 2018

Author Contributor

This comment has been minimized.

@rbiasini

rbiasini Sep 3, 2018

Contributor

yeah, just verified. This msg is at 20Hz, so it needs to be sent every 5 steps (each step is 0.01s).
So CAR.HIGHLANDERH, CAR.HIGHLANDER should just be added to line 37

(0x130, ECU.CAM, (CAR.PRIUS, CAR.RAV4H, CAR.LEXUS_RXH, CAR.RAV4, CAR.COROLLA), 1, 100, '\x00\x00\x00\x00\x00\x00\x38'),
(0x466, ECU.CAM, (CAR.PRIUS, CAR.RAV4H, CAR.LEXUS_RXH, CAR.RAV4), 1, 100, '\x20\x20\xAD'),
(0x466, ECU.CAM, (CAR.PRIUS, CAR.RAV4H, CAR.LEXUS_RXH, CAR.RAV4, CAR.HIGHLANDERH, ), 1, 100, '\x20\x20\xAD'),

This comment has been minimized.

@rbiasini

rbiasini Sep 3, 2018

Contributor

you sure the highlander non-hybrid does not have 0x466?

This comment has been minimized.

@daehahn

daehahn Sep 3, 2018

Author Contributor

We (me and Phil Lee) need to fine tuning those STATIC_MSGS. Let us guide. That this is CAN message map build by myself for these tuning. https://drive.google.com/drive/u/0/folders/1u_K-uB0PXv0OeZ5iUNoRuBdUMMt61LBb

(0x4d3, ECU.CAM, (CAR.PRIUS, CAR.RAV4H, CAR.LEXUS_RXH, CAR.RAV4, CAR.COROLLA), 0, 100, '\x1C\x00\x00\x01\x00\x00\x00\x00'),
(0x367, ECU.CAM, (CAR.HIGHLANDERH, CAR.HIGHLANDER), 0, 40, '\x00\x00'),

(0x411, ECU.DSU, (CAR.HIGHLANDERH, CAR.HIGHLANDER), 0, 100, '\x00\x20\x00\x00\x10\x00\x80\x00'),

This comment has been minimized.

@rbiasini

rbiasini Sep 3, 2018

Contributor

these are alerts already sent in carcontroller (like 0x343). This needs to be removed from here.

(0x367, ECU.CAM, (CAR.HIGHLANDERH, CAR.HIGHLANDER), 0, 40, '\x00\x00'),

(0x411, ECU.DSU, (CAR.HIGHLANDERH, CAR.HIGHLANDER), 0, 100, '\x00\x20\x00\x00\x10\x00\x80\x00'),
(0x412, ECU.CAM, (CAR.HIGHLANDERH, CAR.HIGHLANDER), 0, 100, '\x68\x04\x0a\x00\x00\x2c\x38\x02'),

This comment has been minimized.

@rbiasini

rbiasini Sep 3, 2018

Contributor

these are alerts already sent in carcontroller (like 0x343). This needs to be removed from here.

(0x48a, ECU.CAM, (CAR.PRIUS, CAR.RAV4H, CAR.LEXUS_RXH, CAR.RAV4, CAR.COROLLA), 0, 100, '\x00\x00\x00\x00\x00\x00\x00'),
(0x48b, ECU.CAM, (CAR.PRIUS, CAR.RAV4H, CAR.LEXUS_RXH, CAR.RAV4, CAR.COROLLA), 0, 100, '\x66\x06\x08\x0a\x02\x00\x00\x00'),
(0x4d3, ECU.CAM, (CAR.PRIUS, CAR.RAV4H, CAR.LEXUS_RXH, CAR.RAV4, CAR.COROLLA), 0, 100, '\x1C\x00\x00\x01\x00\x00\x00\x00'),
(0x367, ECU.CAM, (CAR.HIGHLANDERH, CAR.HIGHLANDER), 0, 40, '\x00\x00'),

This comment has been minimized.

@rbiasini

rbiasini Sep 3, 2018

Contributor

the value of this message varies. Sometimes it's set to '\x06\x00'... for simplicity let's remove this line and just add the added Highlander to the previous line.

(0x366, ECU.DSU, (CAR.RAV4, CAR.COROLLA), 0, 20, '\x00\x72\x07\xff\x09\xfe\x00'),
(0x366, ECU.DSU, (CAR.HIGHLANDERH, CAR.HIGHLANDER), 0, 20, '\x00\xb1\x07\xff\x08\xff\x00'),

This comment has been minimized.

@rbiasini

rbiasini Sep 3, 2018

Contributor

0x366 is sent out twice for highlander hybrid

Remove redundancy values in STATIC_MSGS
Also rearrange by category. Suggested by Riccardo at Comma.
@rbiasini

This comment has been minimized.

Copy link
Contributor

rbiasini commented Sep 4, 2018

released with 0.5.3

@rbiasini rbiasini closed this Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment