Skip to content

GM: Auto-resume from stop-and-go - #356

Closed
vntarasov wants to merge 2 commits into
commaai:develfrom
vntarasov:gm-auto-resume
Closed

vntarasov wants to merge 2 commits into
commaai:develfrom
vntarasov:gm-auto-resume

Conversation

@vntarasov

Copy link
Copy Markdown

Through resetting ACC (stopping sending ACC commands until it gets out of standstill) mode and immediately resuming. No need to press resume button anymore!

Piggybacking on @Jamezz's work on smoother braking from #326.

@Jamezz

Jamezz commented Sep 8, 2018

Copy link
Copy Markdown

Just verified this on my own branch. Works great!

@vntarasov

Copy link
Copy Markdown
Author

auto-resume


at_full_stop = enabled and CS.standstill
near_stop = enabled and (CS.v_ego < P.NEAR_STOP_BRAKE_PHASE)
car_stopping = apply_gas < P.ZERO_GAS

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if you are stopping uphill and apply_gas remains positive?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, didn't think of that (didn't test it on very steep hills)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fundamental issue with openpilot's interface design. The stopping intent is never passed up to an interface.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another problem is that GM interface doesn't know if car is moving forward or backwards.

@vntarasov

Copy link
Copy Markdown
Author

Will reopen when steep hill logic (stopping with positive gas) is figured out.

@vntarasov vntarasov closed this Sep 9, 2018
nworb-cire pushed a commit to opgm/openpilot that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants