New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GM: Auto-resume from stop-and-go #356
Conversation
Just verified this on my own branch. Works great! |
dee949a
to
97f9714
Compare
@@ -133,12 +130,18 @@ def update(self, sendcan, enabled, CS, frame, actuators, \ | |||
if (frame % 4) == 0: | |||
idx = (frame / 4) % 4 | |||
|
|||
at_full_stop = enabled and CS.standstill | |||
near_stop = enabled and (CS.v_ego < P.NEAR_STOP_BRAKE_PHASE) | |||
car_stopping = apply_gas < P.ZERO_GAS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if you are stopping uphill and apply_gas remains positive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, didn't think of that (didn't test it on very steep hills)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fundamental issue with openpilot's interface design. The stopping intent is never passed up to an interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another problem is that GM interface doesn't know if car is moving forward or backwards.
Will reopen when steep hill logic (stopping with positive gas) is figured out. |
Through resetting ACC (stopping sending ACC commands until it gets out of standstill) mode and immediately resuming. No need to press resume button anymore!
Piggybacking on @Jamezz's work on smoother braking from #326.