New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GM: Auto-resume from stop-and-go #356

Closed
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@vntarasov
Contributor

vntarasov commented Sep 8, 2018

Through resetting ACC (stopping sending ACC commands until it gets out of standstill) mode and immediately resuming. No need to press resume button anymore!

Piggybacking on @Jamezz's work on smoother braking from #326.

@Jamezz

This comment has been minimized.

Contributor

Jamezz commented Sep 8, 2018

Just verified this on my own branch. Works great!

@vntarasov vntarasov force-pushed the vntarasov:gm-auto-resume branch from dee949a to 97f9714 Sep 8, 2018

@vntarasov

This comment has been minimized.

Contributor

vntarasov commented Sep 8, 2018

auto-resume

@@ -133,12 +130,18 @@ def update(self, sendcan, enabled, CS, frame, actuators, \
if (frame % 4) == 0:
idx = (frame / 4) % 4
at_full_stop = enabled and CS.standstill
near_stop = enabled and (CS.v_ego < P.NEAR_STOP_BRAKE_PHASE)
car_stopping = apply_gas < P.ZERO_GAS

This comment has been minimized.

@rbiasini

rbiasini Sep 9, 2018

Contributor

what happens if you are stopping uphill and apply_gas remains positive?

This comment has been minimized.

@vntarasov

vntarasov Sep 9, 2018

Contributor

ah, didn't think of that (didn't test it on very steep hills)

This comment has been minimized.

@Jamezz

Jamezz Sep 9, 2018

Contributor

This is a fundamental issue with openpilot's interface design. The stopping intent is never passed up to an interface.

This comment has been minimized.

@vntarasov

vntarasov Sep 10, 2018

Contributor

Another problem is that GM interface doesn't know if car is moving forward or backwards.

@vntarasov

This comment has been minimized.

Contributor

vntarasov commented Sep 9, 2018

Will reopen when steep hill logic (stopping with positive gas) is figured out.

@vntarasov vntarasov closed this Sep 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment