Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up
+34
−29
Conversation
This comment has been minimized.
This comment has been minimized.
|
Just verified this on my own branch. Works great! |
vntarasov
force-pushed the
vntarasov:gm-auto-resume
branch
from
dee949a
to
97f9714
Sep 8, 2018
This comment has been minimized.
This comment has been minimized.
|
|
| @@ -133,12 +130,18 @@ def update(self, sendcan, enabled, CS, frame, actuators, \ | ||
| if (frame % 4) == 0: | ||
| idx = (frame / 4) % 4 | ||
| at_full_stop = enabled and CS.standstill | ||
| near_stop = enabled and (CS.v_ego < P.NEAR_STOP_BRAKE_PHASE) | ||
| car_stopping = apply_gas < P.ZERO_GAS |
This comment has been minimized.
This comment has been minimized.
rbiasini
Sep 9, 2018
Contributor
what happens if you are stopping uphill and apply_gas remains positive?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Jamezz
Sep 9, 2018
Contributor
This is a fundamental issue with openpilot's interface design. The stopping intent is never passed up to an interface.
This comment has been minimized.
This comment has been minimized.
vntarasov
Sep 10, 2018
Contributor
Another problem is that GM interface doesn't know if car is moving forward or backwards.
This comment has been minimized.
This comment has been minimized.
|
Will reopen when steep hill logic (stopping with positive gas) is figured out. |
vntarasov
closed this
Sep 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vntarasov commentedSep 8, 2018
Through resetting ACC (stopping sending ACC commands until it gets out of standstill) mode and immediately resuming. No need to press resume button anymore!
Piggybacking on @Jamezz's work on smoother braking from #326.