New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2017 Chevy Malibu #367

Closed
wants to merge 12 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@tylergets

tylergets commented Sep 17, 2018

Currently using all settings from the Chevy Volt, will update with more precise measurements when I am able to get them.

tylergets added some commits Sep 10, 2018

Merge pull request #1 from commaai/devel
Kia Sorento and future Multi-Car Support (#346)

@tylergets tylergets changed the title from Car/malibu to 2017 Chevy Malibu Sep 17, 2018

tylergets added some commits Sep 17, 2018

Show resolved Hide resolved selfdrive/car/gm/values.py Outdated
@rbiasini

This comment has been minimized.

Contributor

rbiasini commented Sep 20, 2018

thanks @tylergets . Is this working? I assume longitudinal control might need some work

@tylergets

This comment has been minimized.

tylergets commented Sep 20, 2018

@rbiasini it's working without fault, both long + lat need some work, however. I am not sure what work that is being done for the general GM tuning in #326 applies here, but I'd be glad to test. I will get a proper cabana drive posted here over the weekend.

Some initial observations, the car seems to brake unnecessarily hard in certain situations, definitely the opposite of smooth. The lkas frequency/step might be off as well.

tylergets added some commits Sep 26, 2018

Merge pull request #5 from tylergets/devel
update malibu branch
@rbiasini

This comment has been minimized.

Contributor

rbiasini commented Oct 26, 2018

@tylergets , is longitudinal tuning still not ok?

@tylergets

This comment has been minimized.

tylergets commented Oct 26, 2018

@rbiasini the current gm tune is a bit aggressive, this applies for the currently supported chevy volt as well. Tuning by @jamezz-comma in #326 and his branches greatly improves this. But because this is no different than the volt, I don't see what stops this from being good to go.

I have also updated interface.py to include the malibu specific curb weight and wheelbase.

@Jamezz

This comment has been minimized.

Contributor

Jamezz commented Oct 27, 2018

As long as the car stops safely I don't see why this can't be merged. The volt longitudinal changes should help a lot with all GM.

@rbiasini

This comment has been minimized.

Contributor

rbiasini commented Nov 7, 2018

@tylergets ok, great. Will merge this for now. GM longitudinal changes from @Jamezz later.

@rbiasini

This comment has been minimized.

Contributor

rbiasini commented Nov 8, 2018

@tylergets I don't see any uploaded log from any MALIBU. Can you please share a cabana route?

@rbiasini

This comment has been minimized.

Contributor

rbiasini commented Nov 12, 2018

@tylergets merged internally. It will be included in 0.5.6

@tylergets

This comment has been minimized.

tylergets commented Nov 15, 2018

Thanks comma team!

@tylergets tylergets closed this Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment