New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis Type 2 Port #502

Closed
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@emmertex
Copy link
Contributor

emmertex commented Jan 15, 2019

Both Port and Tuning work well.
User is 'andrewhlr' on slack

Genesis Type 2 Port
Both Port and Tuning work well.
User is 'andrewhlr' on slack
@rbiasini

This comment has been minimized.

Copy link
Contributor

rbiasini commented Jan 15, 2019

looks good. Thanks.

@rbiasini

This comment has been minimized.

Copy link
Contributor

rbiasini commented Jan 15, 2019

@emmertex , do you happen to have a cabana link to a drive with the GENESIS 2? In case, you can pm it to me on Discord

@emmertex

This comment has been minimized.

Copy link
Contributor Author

emmertex commented Jan 16, 2019

Have sent the link.
Also corrected the year and updated the readme

@rbiasini

This comment has been minimized.

Copy link
Contributor

rbiasini commented Jan 16, 2019

something is not right: the fingerprint I get from the drive you sent me includes 832: 8.

@rbiasini

This comment has been minimized.

Copy link
Contributor

rbiasini commented Jan 16, 2019

Also, since the vehicle params are the same, this should just be a fingerprint addition to the already existing GENESIS

@emmertex

This comment has been minimized.

Copy link
Contributor Author

emmertex commented Jan 16, 2019

I would need to go back and see why, but we used to have 3x Genesis fingerprints, and it was changed to capture 2 of them.

@rbiasini

This comment has been minimized.

Copy link
Contributor

rbiasini commented Jan 16, 2019

In our internal branch I've just added this new fingerprint in GENESIS so this vehicle variant will be supported in next release. I will close this PR for now unless there are reasons for the car params to be different (and currently they are not except for a small delta in min steer speed). Thanks for the port!

@rbiasini rbiasini closed this Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment