Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional IP range for android hotspot #532

Open
wants to merge 8 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@icmma
Copy link

icmma commented Feb 17, 2019

Please see original PR for full logs although i did update code same day but wasn't sure which method was right later found out there was no wrong method at all but couldn't do much since PR was closed before i could do anything. #530

icmma added some commits Feb 9, 2019

Revert "Update thermald.py"
This reverts commit 4239519.
@eFiniLan

This comment has been minimized.

Copy link
Contributor

eFiniLan commented Feb 27, 2019

@icmma would it be more accurate to use ANDROID_METERED to check if you are on a metered network? sorry I don't have the environment to test proxy but that's what I'm getting when I tether from another android phone:

$ dumpsys wifi | grep mDhcpResults
mDhcpResults IP address 192.168.43.77/24 Gateway 192.168.43.193  DNS servers: [ 192.168.43.193 ] Domains DHCP server /192.168.43.193 Vendor info ANDROID_METERED lease 3600 seconds
@pd0wm

This comment has been minimized.

Copy link
Contributor

pd0wm commented Feb 28, 2019

That is pretty interesting. Didn't know about that DHCP option.

@icmma, your PR is breaking functionality for android and iOS users in the default IP ranges.

@icmma

This comment has been minimized.

Copy link
Author

icmma commented Feb 28, 2019

@eFiniLan DHCP is always better.

@icmma

This comment has been minimized.

Copy link
Author

icmma commented Feb 28, 2019

@pd0wm will test it.oir again but I like the DHCP method however need testing to see if it works for proxy as well. @eFiniLan I do use another Android phone where I'm tethering from it's kind of tricky since I don't have tethering plan since it's Android you can always find alternatives one is rooting other is without . I like to make things simple for users in general where they don't have to root phones to get tethering you can find some apps that does it but they use proxy there is another option which is ADB but I found it more user friendly so anyone can do it in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.