Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ignored files in control library #549

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@rhinodavid
Copy link

rhinodavid commented Mar 5, 2019

.gitignore ignores .o, .d, and .so build artifacts, but the control library still includes some checked in to the repo. Remove those files from from the directory and from the repo with git rm --cached.

Verified that .run_docker_tests.sh still completes as expected.

David Walsh

@rhinodavid rhinodavid marked this pull request as ready for review Mar 5, 2019

@pd0wm

This comment has been minimized.

Copy link
Contributor

pd0wm commented Mar 19, 2019

Thanks for your suggestion!

However, these binaries are shipped intentionally. Compiling lateral & longitudinal MPC takes about 10 minutes on an EON. This caused complaints on first use after reinstall because people thought something was broken.

In an ideal scenario we only ship the final .so files, and not the intermediate files (.o, .d). But leaving those out will trigger the Makefile to rebuild everything. If you know an elegant solution for this that would be most welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.