Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display km/h or mph in Honda ACC HUD depending on Eon metrics setting #550

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@kegman
Copy link
Contributor

kegman commented Mar 6, 2019

Currently, when a user engages OP, the set cruise speed is displayed on the HUD. This only displays in mph, regardless of Honda settings or the metric setting in the Eon.

This PR fixes the problem and honours the Eon's metric setting. If metric setting is on, it displays kph in the ACC HUD. If metric setting is off, it displays mph in the ACC HUD. (Note: requires a reboot to take affect once setting is changed)

George Hotz and others added some commits Jan 6, 2019

@rbiasini

This comment has been minimized.

Copy link
Contributor

rbiasini commented Mar 6, 2019

@kegman I would prefer the hud of the car to depend on the unit section on the car itself (not on the EON). I'm pretty sure the unit toggle is broadcasted on CAN.

@kegman

This comment has been minimized.

Copy link
Contributor Author

kegman commented Mar 6, 2019

@rbiasini I would agree with you that using the CAN signal would be better (if I can find it). We could then even do away with the metric setting entirely from the Eon. However I would say that this solution is better than the current implementation, which hardcodes the mph selection in the ACC HUD.

@rbiasini

This comment has been minimized.

Copy link
Contributor

rbiasini commented Mar 6, 2019

I agree the current behavior needs to be fixed and I would rather fix it in a way that scales to all cars (in some cars EON doesn't decide on hud set speed).
It's ok keeping the EON managing its own unit system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.