Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more German zone rules. #557

Closed
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@arne182
Copy link
Contributor

arne182 commented Mar 9, 2019

@rbiasini

This comment has been minimized.

Copy link
Contributor

rbiasini commented Mar 13, 2019

@arne182 can you please run default_speeds_generator.py to generate the new json file?
On next release it will autogenerate

@arne182

This comment has been minimized.

Copy link
Contributor Author

arne182 commented Mar 13, 2019

./default_speeds_generator.py
Traceback (most recent call last):
File "./default_speeds_generator.py", line 215, in
main()
File "./default_speeds_generator.py", line 143, in main
DE.add_rule({"zone:maxspeed": "DE:30"}, "30")
File "./default_speeds_generator.py", line 177, in add_rule
raise ValueError("Rule tag keys must be in allowable tag kesy") # If this is by mistake, please update ALLOWABLE_TAG_KEYS
ValueError: Rule tag keys must be in allowable tag kesy
$

@legonigel

This comment has been minimized.

Copy link
Contributor

legonigel commented Mar 13, 2019

The "zone:maxspeed" is not one of the currently allowed tag keys. You need to add this tag to the list below called ALLOWABLE_TAG_KEYS

@arne182

This comment has been minimized.

Copy link
Contributor Author

arne182 commented Mar 14, 2019

./default_speeds_generator.py
Traceback (most recent call last):
File "./default_speeds_generator.py", line 215, in
main()
File "./default_speeds_generator.py", line 154, in main
write_json(countries)
File "./default_speeds_generator.py", line 159, in write_json
out_dict.update(country.jsonify())
File "./default_speeds_generator.py", line 208, in jsonify
for r_name, region in self.regions.iteritems():
AttributeError: 'dict' object has no attribute 'iteritems'
$

@nanamiwang

This comment has been minimized.

Copy link

nanamiwang commented Mar 14, 2019

seems you are running python2 script under python3 environment. In python3 iteritems is renamed to items

arne182 added some commits Mar 14, 2019

@legonigel

This comment has been minimized.

Copy link
Contributor

legonigel commented Mar 21, 2019

merged internally, will be in next release. Thanks!

@legonigel legonigel closed this Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.