Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port for 2019 Honda CRV Hybrid (China ver) #596

Merged
merged 6 commits into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@eFiniLan
Copy link
Contributor

commented Apr 9, 2019

CRV Hybrid doesn't fit into existing CRV or CRV_5G.

Stock Log
OP Log

eFiniLan added some commits Apr 8, 2019

Merge branch 'devel-2019-honda-crv-hybrid' of https://github.com/eFin…
…iLan/openpilot into devel-2019-honda-crv-hybrid

# Conflicts:
#	selfdrive/car/honda/interface.py
Merge branch 'devel' of https://github.com/commaai/openpilot into dev…
…el-2019-honda-crv-hybrid

# Conflicts:
#	selfdrive/car/honda/carstate.py

@eFiniLan eFiniLan changed the title Add port to 2019 Honda CRV Hybrid (China ver) Add port for 2019 Honda CRV Hybrid (China ver) Apr 9, 2019

@rbiasini

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

looks good. @eFiniLan . I wonder if the max steer is really 0x1000. On stock drive I see 0xf00 as max. Not a big deal.

Could you please add the newly supported CRV Hybrid 2019 to the list of supported cars in the README.md file?

@eFiniLan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@rbiasini cheers! yeah we also noticed that, with LDW the highest is 0xF00 and 0xA00 without. The highest support value is 0x1000 and anything more than that the steer stop turning. I'll get the owner to run a couple more tests on those 3 values and submit another PR later if necessary.

README update is done ;)

@rbiasini rbiasini merged commit 7978afa into commaai:devel Apr 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.