Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSM monthly conditional speed limits support #618

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@martinl
Copy link

commented Apr 25, 2019

Adds support for OSM monthly conditional speed limits eg. maxspeed:conditional=110 @ Apr-Oct

Most major highways here have higher speeds during summer months and also OSM conditional speed limits defined.

Ref: https://wiki.openstreetmap.org/wiki/Conditional_restrictions#Condition

Martin

@pd0wm

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

Do you have the way id of a road with a monthly speed limit? I'd like to create some tests for parsing the speed limits.

@martinl

This comment has been minimized.

Copy link
Author

commented May 9, 2019

Here are two sample way id-s with monthly speed limits: 363155579 and 241765616

@arne182

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

In Germany the conditional speeds are different. Limiting them by time should only be done for that specific country.

@martinl

This comment has been minimized.

Copy link
Author

commented May 11, 2019

I think it would make sense to add support for other OSM maxspeed conditions which are used on the map and which openpilot can use for setting the ACC speed limit

@arne182 can you please provide some way id-s from Germany with different conditional speed limits

@arne182

This comment has been minimized.

Copy link
Contributor

commented May 11, 2019

What you might be looking for is maxspeed:seasonal:winter

from here
https://wiki.openstreetmap.org/wiki/Talk:Key:maxspeed

https://cdn.discordapp.com/attachments/533308698077036551/576845064274444308/imago62881833h.jpg

commaai/opendbc@e18ba36

maxspeed:backward=100
maxspeed:forward=100
maxspeed:forward:wet=80
source:maxspeed:backward=DE:rural
source:maxspeed:forward=DE:rural
source:maxspeed:forward:wet=sign

I have not found a way id that uses this. I just know my RSA can read the signs and when we finish writing the street sign recorder this will be one of the signs to be picked up on German roads. If you want I could run through all the conditional signs on my Toyota RSA

@martinl

This comment has been minimized.

Copy link
Author

commented May 12, 2019

I did some overpass queries (http://overpass-turbo.eu/s/IUQ) to get an overview of different maxspeed subtags being used in OSM in different parts of the world:

  • maxspeed:conditional is used often in different parts of the world, including Germany
  • maxspeed:seasonal:winter is only used in Finland
  • maxspeed:backward, maxspeed:forward - both are used often, mostly in EU and US
  • maxspeed:forward:wet, maxspeed:backward:wet - not used
  • maxspeed:wet some use, mostly EU, US, AU

@arne182, you are welcome to implement support for additional tags and do a separate PR, since current PR only applies to maxspeed:conditional. I think forward, backward and wet tags would need additional data and logic to decide which speed limit condition currently applies. Implementing maxspeed:seasonal:winter tag would need either manual toggle in UI or some other definition of winter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.