Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Subaru XV 2018 support #633

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@martinl
Copy link

commented May 9, 2019

Complete port for Subaru XV 2018. Tested with my car, custom Subaru wiring harness and https://github.com/martinl/openpilot/tree/subaru-devel2

PS. I also noticed bounty offer in selfdrive/car/car_helpers.py, I would like to use the bounty

@rbiasini

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

@martinl oh, did not realize that the Impreza and the XV are actually the exact same platform (I was under the impression it needed different tuning and params). So the cleanest solution is just changing values.py and recognize the XV fingerprint as an Impreza without creating a new car model at all.

Merged it internally. Will be supported in upcoming release. Thanks!

@rbiasini rbiasini closed this May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.