Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openpilot lane line indicators support for Subaru global dash display #637

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@martinl
Copy link

commented May 11, 2019

This PR adds Openpilot lane lines visible indicators support for Subaru global dash display. Tested and working with Subaru XV 2018


values = copy.copy(es_lkas_msg)
if visual_alert == VisualAlert.steerRequired:
values["Keep_Hands_On_Wheel"] = 1

if left_line:
values["LKAS_Left_Line_Visible"] = 1

This comment has been minimized.

Copy link
@rbiasini

rbiasini May 12, 2019

Contributor

values["LKAS_Left_Line_Visible"] = int(left_line)
values["LKAS_Right_Line_Visible"] = int(right_line)

@rbiasini

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

Nice. Just one comment I would resolve before merge.
Also, for the dbc changes, can you please open a PR in opendbc repo first? That needs to be merged before this can.

if (addr == 0x122) {
return -1;
}
// ES Distance
if (addr == 545) {
return -1;
}
// ES LKAS State

This comment has been minimized.

Copy link
@rbiasini

rbiasini May 12, 2019

Contributor

Nice catch, this change was needed beside this PR.

@rbiasini

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

Ended up cleaning this PR and merging it internally. Will be in next OP release. Thanks.

@rbiasini rbiasini closed this May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.