Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registration's params get_git_remote() #673

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
2 participants
@rafcabezas
Copy link
Contributor

commented May 31, 2019

registration's get_git_remote() currently returns potentially the incorrect git remote if the user has multiple remotes set up.

Thanks to @SippieCup for reporting the problem!

@geohot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Looking into it now.

@geohot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

So we have code in selfdrive/version to do this as well. Needs to be refactored before merging

@rafcabezas

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

Gotcha, I'll take a look

@geohot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Going to merge, we'll refactor internally.

@geohot geohot merged commit 0aa41e3 into commaai:devel May 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.