Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panda fw and dongle id to params #695

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@martinl
Copy link
Contributor

commented Jun 12, 2019

This PR gets Panda firmware version and Panda dongle ID and adds them to params. I will submit separate PR to offroad apk to show them under Developer menu

@martinl

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

openpilot-apks PR commaai/openpilot-apks#12

@geohot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Can you fix the CI?

@geohot geohot added the enhancement label Jun 12, 2019

@geohot

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Hmm, is this tested?

I was about to merge your apk PR, but then I read this code. Is Params imported?

Also, these should really be set from boardd, because what if I unplug and replug a panda?

@martinl

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

Fixed the CI and set up local docker for running tests before next PR. Replugging and swapping pandas is a good point, I'll reimplement setting the panda params in boardd

@geohot

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

When that's done, I'll merge.

@rbiasini

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

Or you could add the rule CLEAR_ON_PANDA_DISCONNECT.

@geohot

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

That will clear them, but it won't readd them for the new panda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.