Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2018 Civic Hatchback 1.0l CVT (European) support #823

Merged
merged 2 commits into from Oct 3, 2019

Conversation

@csouers
Copy link
Contributor

commented Sep 29, 2019

Basically the same as as current civic bosch cars. No major complaints from the discord user, Noillek.

I include a comment in README.MD that we also support european spec versions of this car. I can remove this if desired.

test_fingerprints returns fine

Update README.md
@rbiasini

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2019

As usual, we need a cabana link. Thanks! And yes, I don't think the change in README is necessary.

@csouers

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

The fingerprint for this car encompasses the previous fingerprint (combo of the 2017 and the 2019 canadian model, plus these three frames. 460: 3, 1625: 5, 1629: 5

@rbiasini

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

confirmed. Haven't found msg 1633 in the drive you posted, but that's ok. Not worth separating the fingerprints for such a low frequency message.
Thanks!

@rbiasini rbiasini merged commit 1bc51d6 into commaai:devel Oct 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
JasonJShuler added a commit to JasonJShuler/openpilot that referenced this pull request Oct 5, 2019
Add 2018 Civic Hatchback 1.0l CVT (European) support (commaai#823)
jyoung8607 added a commit to jyoung8607/openpilot that referenced this pull request Oct 10, 2019
* Add 2018 Civic Hatchback 1.0l CVT support

test_fingerprints returns fine
@csouers csouers deleted the csouers:2018_10l_civic branch Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.