Added convenience methods to update, clear and destroy plugin #4

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
2 participants
@jmpease

jmpease commented Apr 10, 2012

  • Added an "update" method that allows changing of autoComplete settings after the plugin has been initialized on an element.
  • Added a "clear" method that empties the target listview. Useful for clearing the list in response to non-"input" events.
  • Added a "destroy" method to unbind event handler and clear stored plugin data. Useful when plugin functionality is no-longer required.
  • Added namespaced targetUpdated and targetCleared events.
  • Calling unbind before bind in initializer to avoid redundant handling in case plugin is re-initialized on an element.
  • Fixed clearing of target listview when input length is less than minLength, rather than 1.
  • Added Eclipse project metadata for consistency amongst developers using Eclipse.

jmpease added some commits Apr 9, 2012

@jmpease

This comment has been minimized.

Show comment Hide comment
@jmpease

jmpease Apr 10, 2012

Oops...bad timing it seems. Missed the recent upstream update to 1.2. I'll look into merging these into this request.

jmpease commented Apr 10, 2012

Oops...bad timing it seems. Missed the recent upstream update to 1.2. I'll look into merging these into this request.

Merge remote-tracking branch 'upstream/master'
Conflicts:
	jqm.autoComplete-1.1.1.js
	jqm.autoComplete-1.2.js
	old/jqm.autoComplete-1.1.1.js
@commadelimited

This comment has been minimized.

Show comment Hide comment
@commadelimited

commadelimited Apr 10, 2012

Owner

LOL. I just did it this morning. These additions sound awesome JM.

Owner

commadelimited commented Apr 10, 2012

LOL. I just did it this morning. These additions sound awesome JM.

@jmpease

This comment has been minimized.

Show comment Hide comment
@jmpease

jmpease Apr 10, 2012

I merged in the changes from the upstream 1.2 version into a new 1.3 version including my changes. Take a look and let me know what you think.

Re formatting...I stuck with a local customization of the Eclipse JS formatter. Let me know what convention(s) you prefer (e.g. tab policy, indent size, brace positions) and I can modify the settings appropriately.

jmpease commented Apr 10, 2012

I merged in the changes from the upstream 1.2 version into a new 1.3 version including my changes. Take a look and let me know what you think.

Re formatting...I stuck with a local customization of the Eclipse JS formatter. Let me know what convention(s) you prefer (e.g. tab policy, indent size, brace positions) and I can modify the settings appropriately.

@commadelimited

This comment has been minimized.

Show comment Hide comment
@commadelimited

commadelimited Apr 20, 2012

Owner

Jim...

I'm going to be pushing these changes to the repo but I wasn't able to merge them in as I had already made some other changes. I'm going to make sure you're credited however.

Owner

commadelimited commented Apr 20, 2012

Jim...

I'm going to be pushing these changes to the repo but I wasn't able to merge them in as I had already made some other changes. I'm going to make sure you're credited however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment