New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new values for expected_version #127

Merged
merged 2 commits into from Sep 21, 2018

Conversation

Projects
None yet
2 participants
@leifg
Copy link
Contributor

leifg commented Jan 20, 2018

The eventstore backend allows to skip the expected version check: (https://github.com/commanded/eventstore/blob/2d031e73a668fb518fc96f0670ccc6ed1deb5bc8/lib/event_store.ex#L44)

This PR will extend this feature to the InMemory adapter.

PR for eventstore-adapter will follow

leifg added some commits Jan 20, 2018

@slashdotdash

This comment has been minimized.

Copy link
Member

slashdotdash commented Feb 5, 2018

This requires making a breaking change to the EventStore library since it only supports returning an :ok response when appending events.

I'm somewhat hesitant to make this change without a strong need to.

@slashdotdash slashdotdash force-pushed the commanded:master branch from dcc4502 to e861f48 Mar 11, 2018

@slashdotdash slashdotdash force-pushed the commanded:master branch 3 times, most recently from 5cfda8f to 784bb61 Aug 26, 2018

@slashdotdash slashdotdash merged commit afae615 into commanded:master Sep 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

slashdotdash added a commit that referenced this pull request Sep 21, 2018

slashdotdash added a commit that referenced this pull request Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment