New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary else #230

Merged
merged 1 commit into from Nov 25, 2018

Conversation

Projects
None yet
2 participants
@joaothallis
Contributor

joaothallis commented Nov 25, 2018

With the error being returned without any changes, you do not need the else, only if you want to be explicit

@slashdotdash slashdotdash merged commit f123a29 into commanded:master Nov 25, 2018

@slashdotdash

This comment has been minimized.

Member

slashdotdash commented Nov 25, 2018

Good catch, I'd forgotten that's the default behaviour of the with clause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment