Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Global option values ignored when args provided #88

Merged
merged 2 commits into from Mar 8, 2020

Conversation

@orien
Copy link
Contributor

orien commented Mar 8, 2020

Context

As detailed in #86, global options are ignored when command specific options or arguments are provided.

Proposed Solution

Separate the global options from the command specific options. This prevents the global options from being cleared when the command specific options are parsed.

Fixes #86.

orien and others added 2 commits Mar 8, 2020
Separate the global options from the command specific options. This
prevents the global options from being cleared when the command specific
options are parsed.
spec/command_spec.rb Show resolved Hide resolved
@ggilder
ggilder approved these changes Mar 8, 2020
@ggilder ggilder merged commit 564896e into commander-rb:master Mar 8, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ggilder

This comment has been minimized.

Copy link
Member

ggilder commented Mar 8, 2020

Just released in v4.5.1. Thanks for fixing this!

@orien orien deleted the orien:dont-clear-global-options branch Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.