Make receipt verification ENS-first and gate local fallback behind explicit mode#323
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
resolveSignerFromEnsinlib/verifyReceipt.jsto attempt resolution of the required TXT keys (cl.sig.pub,cl.sig.kid,cl.sig.canonical,cl.receipt.signer) first, and record resolver exceptions askey_resolution_failedvs missing data asens_key_unavailable.runtime.commandlayer.eth) and enabled only whenallowLocalFallbackis passed,COMMANDLAYER_ALLOW_LOCAL_KEY_FALLBACK=true, orNODE_ENV === 'test', and report sources asens_txtorlocal_test_fallbackviapublic_key_source.tests/verifyReceipt-runtime.test.jsto cover resolver-throw (key_resolution_failed) and env-flag gated fallback behavior, and updatetests/api-verify.test.jsto assertpublic_key_source === 'ens_txt'for ENS-path responses.lib/verifyReceipt.js,tests/verifyReceipt-runtime.test.js, andtests/api-verify.test.js.Testing
npm test, all tests passed (105 passed, 0 failed).npm run check:links, all local links/assets resolved successfully.Codex Task