refactor(ProductSearch): disable markMatchingVariants by default

BREAKING CHANGE: markMatchingVariants has been disabled by default

  For performance reasons the markMatchingVariants flag has been disabled by default. In order to use markMatchingVariants feature please enable it explicit.

  Before:
  ```
  $request = ProductProjectionSearchRequest::of();
  ```

  After:
  ```
  $request = ProductProjectionSearchRequest::of()->markMatchingVariants(true);
  ```

Author: Jens Schulze

src/Request/Products/ProductProjectionSearchRequest.php

@@ -53,6 +53,7 @@ class ProductProjectionSearchRequest extends AbstractProjectionRequest implement
     public function __construct(Context $context = null)
     {
         parent::__construct(ProductProjectionEndpoint::endpoint(), $context);
+        $this->markMatchingVariants(false);
     }
 
     /**
@@ -173,7 +174,7 @@ public function fuzzy($level)
     public function markMatchingVariants($mark)
     {
         $this->addParamObject(new Parameter('markMatchingVariants', $mark));
-        
+
         return $this;
     }
 

tests/unit/Request/Products/ProductProjectionSearchRequestTest.php

@@ -27,7 +27,7 @@ public function testFuzzy()
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame('fuzzy=true', (string)$httpRequest->getBody());
+        $this->assertContains('fuzzy=true', (string)$httpRequest->getBody());
     }
 
     public function testMarkMatchingVariant()
@@ -56,6 +56,18 @@ public function testDontMarkMatchingVariant()
         $this->assertSame('markMatchingVariants=false', (string)$httpRequest->getBody());
     }
 
+    public function testMarkMatchingVariantDefault()
+    {
+        /**
+         * @var ProductProjectionSearchRequest $request
+         */
+        $request = $this->getRequest(static::PRODUCT_PROJECTION_SEARCH_REQUEST);
+        $httpRequest = $request->httpRequest();
+
+        $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
+        $this->assertSame('markMatchingVariants=false', (string)$httpRequest->getBody());
+    }
+
     public function fuzzyProvider()
     {
         return [
@@ -82,7 +94,7 @@ public function testFuzzyLevel($level, $expected)
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame($expected, (string)$httpRequest->getBody());
+        $this->assertContains($expected, (string)$httpRequest->getBody());
     }
 
     public function testMapResult()
@@ -114,7 +126,7 @@ public function testAddFilterString()
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame('filter=key%3A%22value%22', (string)$httpRequest->getBody());
+        $this->assertContains('filter=key%3A%22value%22', (string)$httpRequest->getBody());
     }
 
     public function testAddMultiFilterString()
@@ -128,7 +140,7 @@ public function testAddMultiFilterString()
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame('filter=foo%3A%22bar%22&filter=key%3A%22value%22', (string)$httpRequest->getBody());
+        $this->assertContains('filter=foo%3A%22bar%22&filter=key%3A%22value%22', (string)$httpRequest->getBody());
     }
 
     public function testAddFilterInt()
@@ -141,7 +153,7 @@ public function testAddFilterInt()
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame('filter=key%3A10', (string)$httpRequest->getBody());
+        $this->assertContains('filter=key%3A10', (string)$httpRequest->getBody());
     }
 
     public function testAddFilterArray()
@@ -154,7 +166,7 @@ public function testAddFilterArray()
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame('filter=key%3A10%2C20%2C30', (string)$httpRequest->getBody());
+        $this->assertContains('filter=key%3A10%2C20%2C30', (string)$httpRequest->getBody());
     }
 
     public function testAddFilterQuery()
@@ -167,7 +179,7 @@ public function testAddFilterQuery()
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame('filter.query=key%3A%22value%22', (string)$httpRequest->getBody());
+        $this->assertContains('filter.query=key%3A%22value%22', (string)$httpRequest->getBody());
     }
 
     public function testAddFilterQueryFacet()
@@ -181,7 +193,7 @@ public function testAddFilterQueryFacet()
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame('facet=key%3A%22value%22&filter.query=key%3A%22value%22', (string)$httpRequest->getBody());
+        $this->assertContains('facet=key%3A%22value%22&filter.query=key%3A%22value%22', (string)$httpRequest->getBody());
     }
 
     public function testAddMultiFilterQuery()
@@ -195,7 +207,7 @@ public function testAddMultiFilterQuery()
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame(
+        $this->assertContains(
             'filter.query=foo%3A%22bar%22&filter.query=key%3A%22value%22',
             (string)$httpRequest->getBody()
         );
@@ -211,7 +223,7 @@ public function testAddFilterFacets()
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame('filter.facets=key%3A%22value%22', (string)$httpRequest->getBody());
+        $this->assertContains('filter.facets=key%3A%22value%22', (string)$httpRequest->getBody());
     }
 
     public function testAddMultiFilterFacets()
@@ -225,7 +237,7 @@ public function testAddMultiFilterFacets()
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame(
+        $this->assertContains(
             'filter.facets=foo%3A%22bar%22&filter.facets=key%3A%22value%22',
             (string)$httpRequest->getBody()
         );
@@ -241,7 +253,7 @@ public function testAddFacet()
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame('facet=key%3A%22value%22', (string)$httpRequest->getBody());
+        $this->assertContains('facet=key%3A%22value%22', (string)$httpRequest->getBody());
     }
 
     public function testAddMultiFacet()
@@ -255,7 +267,7 @@ public function testAddMultiFacet()
         $httpRequest = $request->httpRequest();
 
         $this->assertSame('product-projections/search', (string)$httpRequest->getUri());
-        $this->assertSame('facet=foo%3A%22bar%22&facet=key%3A%22value%22', (string)$httpRequest->getBody());
+        $this->assertContains('facet=foo%3A%22bar%22&facet=key%3A%22value%22', (string)$httpRequest->getBody());
     }
 
     public function testHttpRequestMethod()
@@ -279,7 +291,7 @@ public function testHttpRequestObject()
         $request = ProductProjectionSearchRequest::of();
         $httpRequest = $request->httpRequest();
 
-        $this->assertEmpty((string)$httpRequest->getBody());
+        $this->assertSame('markMatchingVariants=false', (string)$httpRequest->getBody());
     }
 
     public function testBuildResponse()