feat(Attribute): enhance getting attribute by name from attributes collection

Author: Jens Schulze

src/Core/Model/Common/AttributeCollection.php

@@ -44,6 +44,23 @@ public function __get($attributeName)
         return null;
     }
 
+    public function __call($name, $arguments)
+    {
+        if (strpos($name, 'get') === 0) {
+            $name = lcfirst(substr($name, 3));
+        }
+        return $this->getByName($name);
+    }
+
+
+    public function offsetGet($offset)
+    {
+        if (is_string($offset)) {
+            return $this->getByName($offset);
+        }
+        return $this->getAt($offset);
+    }
+
     /**
      * @param $attributeName
      * @return Attribute|null

tests/unit/Model/Common/AttributeCollectionTest.php

@@ -72,6 +72,29 @@ public function testAttributeAs()
         $this->assertInstanceOf(Enum::class, $attributes->getByName('collection-enum-set')->getValueAsEnumSet()->getAt(0));
     }
 
+    public function testAttributeByNameArrayAccess()
+    {
+        $collection = AttributeCollection::of();
+        $collection->add(Attribute::fromArray(['name' => 'test', 'value' => 'Test']));
+
+        $this->assertSame('Test', $collection['test']->getValue());
+    }
+
+    public function testAttributeByNameMagicCall()
+    {
+        $collection = AttributeCollection::of();
+        $collection->add(Attribute::fromArray(['name' => 'test', 'value' => 'Test']));
+
+        $this->assertSame('Test', $collection->test()->getValue());
+        $this->assertSame('Test', $collection->getTest()->getValue());
+    }
+
+    public function testAttributeByPositionArrayAccess()
+    {
+        $collection = AttributeCollection::of();
+        $collection->add(Attribute::fromArray(['name' => 'test', 'value' => 'Test']));
+        $this->assertSame('Test', $collection[0]->getValue());
+    }
 
     public function testMagicGetNotSet()
     {