Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should retry on API errors like 5xx #31

Closed
butenkor opened this issue May 5, 2017 · 2 comments
Closed

Should retry on API errors like 5xx #31

butenkor opened this issue May 5, 2017 · 2 comments

Comments

@butenkor
Copy link
Member

butenkor commented May 5, 2017

Affects all modules (should be covered by JVM SDK)

@heshamMassoud heshamMassoud modified the milestones: 1.0.0-M1, Before category parallelisation May 10, 2017
@ghost ghost mentioned this issue May 19, 2017
2 tasks
@ghost
Copy link

ghost commented Jun 6, 2017

Proposed solution:

  • provide utility function which wraps a sphere client in RetrySphereClientDecorator
  • use that function in a services' constructors (cause they are responsible for performing CRUD operations on CTP and they take a sphereClient as a parameter)

@butenkor I'm not sure about the strategy regarding calculation of waiting time between subsequent retry attemps. Could you provide me expected numbers so that it was reasonable?
E.g. Would a sequence 2s, 2s, 2s, 4s, 4s, 4s, ... , 512s, 512s, 512s of waiting time between following attempts be ok? It would result in 27 attempts, lasting almost 2 hours in a case of the constant failure.

@ghost ghost self-assigned this Jun 6, 2017
@ghost ghost mentioned this issue Jun 7, 2017
@heshamMassoud heshamMassoud modified the milestones: Before category parallelisation, 1.0.0-M1 Jun 19, 2017
@heshamMassoud
Copy link
Contributor

Doesn't have to be a responsibility of the sync library. Showing an example in integration tests should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants