Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refetch and recalculate actions on concurrency modification exception retry in productType sync #325

Closed
heshamMassoud opened this issue Oct 24, 2018 · 1 comment
Closed

Refetch and recalculate actions on concurrency modification exception retry in productType sync #325

heshamMassoud opened this issue Oct 24, 2018 · 1 comment
Assignees
@heshamMassoud
Milestone
1.0.0-M15

Comments

@heshamMassoud
Copy link
Contributor

A new fresh copy of the productType should be refetched in case a concurrency modification exception occurs during the sync. Consequently, update actions should be recalculated on the fresh copy. Otherwise, the resulting productType would be inconsistent.

Related: #94
@heshamMassoud heshamMassoud added this to the 1.0.0-M16 milestone Oct 24, 2018
@ahmetoz ahmetoz mentioned this issue Nov 13, 2018
Merged
5 tasks
@heshamMassoud heshamMassoud modified the milestones: 1.0.0-M16, 1.0.0-M15 Nov 21, 2018
@heshamMassoud heshamMassoud self-assigned this Nov 21, 2018
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Remove redundant comment.
7f5c558
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Fix indentation.
19150a2
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Apply beforeUpdateCallback out of the buildActions utils.
47da023
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Make ProductTypeServiceImpl extend BaseService.
1169172
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Remove publish and revert product services.
40395f6
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Add generic Javadocs.
c275a52
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Fuse toArray into Stream chain.
325ed1d
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Remove tight coupling of applyCreateCallback from create services.
1c7d2c7
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Use correct generic extends in BaseService.
0a6f5bb
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Remove coupling of applyCreateCallback from actual create logic.
b75931c
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Move createResources services out of services to sync.
9cc4b57
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Fix indentation.
c7030df
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Remove service interfaces.
e415da9
heshamMassoud added a commit that referenced this issue Nov 24, 2018
@heshamMassoud
#325: Handle concurrency modification exception in ProductType sync.
636ea7d
heshamMassoud added a commit that referenced this issue Nov 25, 2018
@heshamMassoud
#325: Fix creation key validation condition.
2bd8a66
heshamMassoud added a commit that referenced this issue Nov 25, 2018
@heshamMassoud
#325: Fix unit tests.
9313393
heshamMassoud added a commit that referenced this issue Nov 25, 2018
@heshamMassoud
#325: Fix unit tests.
b3e4be4
heshamMassoud added a commit that referenced this issue Nov 25, 2018
@heshamMassoud
#325: Ignore callback unit tests and as TODO for now.
7c7a5a8
heshamMassoud added a commit that referenced this issue Nov 25, 2018
@heshamMassoud
#325: Fix IT.
1c28726
heshamMassoud added a commit that referenced this issue Nov 25, 2018
@heshamMassoud
#325: Revert assertion change.
2c19a37
heshamMassoud added a commit that referenced this issue Nov 25, 2018
@heshamMassoud
#325: Move createResource to BaseService.
b8fae75
heshamMassoud added a commit that referenced this issue Nov 25, 2018
@heshamMassoud
#325: Fix productType creation service ITs.
de13f8a
heshamMassoud added a commit that referenced this issue Nov 25, 2018
@heshamMassoud
#325: Explicitly complete with an empty optional.
e5afcde
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#325: Move method and add TODO.
c2302ce
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#325: Handle fail on concurrency modification exception retry fetch.
86f57ab
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#325: Fix assertions.
275a3cd
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#325: Fix error message order of format params.
978b2b9
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#325: Fix error messages and assertions.
05aa759
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#325: Remove unneeded test.
ed23a48
heshamMassoud added a commit that referenced this issue Nov 30, 2018
@heshamMassoud
#325: Remove done TODO.
420050d
heshamMassoud added a commit that referenced this issue Dec 1, 2018
@heshamMassoud
#325: Fix assertions.
c89214a
heshamMassoud added a commit that referenced this issue Dec 1, 2018
@heshamMassoud
#325: Fix IT assertions.
bf71946
heshamMassoud added a commit that referenced this issue Dec 2, 2018
@heshamMassoud
#325: Add ITs for concurrency modification exception handling.
2b98cd7
heshamMassoud added a commit that referenced this issue Dec 2, 2018
@heshamMassoud
#325: Statically import Collections#singletonList.
f5de70f
heshamMassoud added a commit that referenced this issue Dec 2, 2018
@heshamMassoud
#325: Make error messages consistent.
c54597c
heshamMassoud added a commit that referenced this issue Dec 2, 2018
@heshamMassoud
#325: Use correct error messages.
901bcc4
heshamMassoud added a commit that referenced this issue Dec 2, 2018
@heshamMassoud
#325: Add unit tests for failed productType fetch service.
dadc6d0
heshamMassoud added a commit that referenced this issue Dec 2, 2018
@heshamMassoud
#325: Add a private constructor class for the util.
a47fff3
heshamMassoud added a commit that referenced this issue Dec 3, 2018
@heshamMassoud
#325: Add IT for filter french locales on sync.
94dbad2
heshamMassoud added a commit that referenced this issue Dec 3, 2018
@heshamMassoud
#325: Add integration tests for productType concurrency modification …
6bb20cc 
…exception.
heshamMassoud added a commit that referenced this issue Dec 3, 2018
@heshamMassoud
#325: Add handeling for concurrency modification exception of product…
13822fe 
… type sync.
heshamMassoud added a commit that referenced this issue Dec 3, 2018
@heshamMassoud
#325: Add unit tests for fetch product type service.
62d934f
@heshamMassoud heshamMassoud mentioned this issue Dec 4, 2018
Merged
4 tasks
heshamMassoud added a commit that referenced this issue Dec 4, 2018
@heshamMassoud
#325: Fix assertions.
731c4ac
heshamMassoud added a commit that referenced this issue Dec 4, 2018
@heshamMassoud
#325: Add release notes.
5fc4f15
heshamMassoud added a commit that referenced this issue Dec 4, 2018
@heshamMassoud
#325: Fix typo in release notes.
e212251
heshamMassoud added a commit that referenced this issue Dec 4, 2018
@heshamMassoud
#325: Fix typos.
13a61ae
heshamMassoud added a commit that referenced this issue Dec 4, 2018
@heshamMassoud
#325: Remove potentially.
645a13e
heshamMassoud added a commit that referenced this issue Dec 5, 2018
@heshamMassoud
#325: Remove redundant methods.
3861990
heshamMassoud added a commit that referenced this issue Dec 5, 2018
@heshamMassoud
#325: Remove conflicts.
4801b0e
@heshamMassoud
Copy link
Contributor Author

Released in 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heshamMassoud heshamMassoud

Labels
None yet
Projects
None yet
Milestone
1.0.0-M15
Development

No branches or pull requests
1 participant
@heshamMassoud