Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upgrade to jest v26 #1481

Merged
merged 1 commit into from May 8, 2020
Merged

refactor: upgrade to jest v26 #1481

merged 1 commit into from May 8, 2020

Conversation

tdeekens
Copy link
Contributor

@tdeekens tdeekens commented May 7, 2020

Summary

Jest v26 is out (https://jestjs.io/blog/2020/05/05/jest-26). The upgrade here should be relatively smooth due to the jsdom v16 adoption work earlier.

@vercel
Copy link

vercel bot commented May 7, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/m039tquck
✅ Preview: https://merchant-center-application-kit-git-refactor-jest-26.commercetools.now.sh

tdeekens
tdeekens commented May 7, 2020
View reviewed changes
jest.test.config.js
@@ -12,5 +12,5 @@ module.exports = {
// Transpile also our local packages as they are only symlinked.
'node_modules/(?!(@commercetools-[frontend|backend]+)/)',
],
testEnvironment: 'jest-environment-jsdom-sixteen',
testEnvironment: 'jsdom',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsdom "standard" now uses v16 of jsdom. The sixteen variant is not really needed anymore. I suggest however we keep the jest-present-for-jsdom-sixteen with the jest-environment-jsdom-sixteen as it otherwise would be breaking. We could there remove the jest-environment-jsdom-sixteen to jsdom but that could also be another PR at some point or just when it's removed.

@tdeekens tdeekens requested a review from emmenko May 7, 2020 08:00
@tdeekens tdeekens self-assigned this May 7, 2020
@tdeekens tdeekens added the 🤖 Type: Dependencies Dependency updates or something similar label May 7, 2020
@emmenko
Copy link
Member

emmenko commented May 7, 2020

Finally ESM support: https://jestjs.io/blog/2020/05/05/jest-26#native-esm-support

@tdeekens
Copy link
Contributor Author

tdeekens commented May 7, 2020

Finally ESM support: https://jestjs.io/blog/2020/05/05/jest-26#native-esm-support

Yup. It‘s super neat. Still, anything missing on this PR?

emmenko
emmenko approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that everything is fine. Thanks! 👌

@emmenko emmenko merged commit 9c48478 into master May 8, 2020
@emmenko emmenko deleted the refactor/jest-26 branch May 8, 2020 06:44
@tdeekens
Copy link
Contributor Author

tdeekens commented May 8, 2020

Thanks

@emmenko emmenko mentioned this pull request May 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmenko emmenko emmenko approved these changes

Assignees

@tdeekens tdeekens

Labels
🤖 Type: Dependencies Dependency updates or something similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tdeekens @emmenko