Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Care less about the particular name of a GHCJS sdist folder #1622

Closed
3noch opened this issue Jan 8, 2016 · 4 comments
Closed

Care less about the particular name of a GHCJS sdist folder #1622

3noch opened this issue Jan 8, 2016 · 4 comments

Comments

@3noch
Copy link
Member

@3noch 3noch commented Jan 8, 2016

I wrote a script a while back for faking out stack so it would accept newer GHCJS sdists.

As @mgsloan noted in the comments, this could be avoided if stack wasn't so persnickety about how the archive's folder is named. All I need to do in my script, is rename the folder within the sdist archive to match the compiler format (e.g. "ghcjs-0.2.0.20160107_ghc-7.10.2").

A potential method (what my script is doing) would be to just assume any folder named "ghcjs-*" within the archive is what stack needs and then copy that to the appropriate location and boot it.

@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Jan 8, 2016

Agreed! Added to my TODO list.

@mgsloan mgsloan added this to the P2: Should milestone Jan 8, 2016
@3noch 3noch changed the title Make `stack` care less about the particular name of a GHCJS sdist folder Care less about the particular name of a GHCJS sdist folder Jan 9, 2016
mgsloan added a commit that referenced this issue Jan 10, 2016
@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Jan 10, 2016

Done!

@mgsloan mgsloan closed this Jan 10, 2016
@3noch
Copy link
Member Author

@3noch 3noch commented Jan 11, 2016

😀 Awesome!

@bergey
Copy link
Contributor

@bergey bergey commented Jan 12, 2016

Thanks so much! I've also been getting by with hacks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.