Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a pretty-printer and polish formatting of output #1912

Closed
mgsloan opened this issue Mar 14, 2016 · 3 comments
Closed

Use a pretty-printer and polish formatting of output #1912

mgsloan opened this issue Mar 14, 2016 · 3 comments

Comments

@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Mar 14, 2016

I think it'd be a good idea to start using a pretty printer! ansi-wl-pprint fits the task quite nicely.

Bonus points would be to use annotated-wl-pprint, and use the annotations to do the same thing that ansi-wl-pprint can do with coloring text and such. (I imagine those annotations would also make a good addition to that libary)

I'm imagining having some utility functions that allow you to do $logPretty, $logPrettyError, or $logPrettyWarn. When used, these would have the type (MonadLogger m, HasPrettyOptions env, MonadReader env m) => Doc -> m (). In other words, we need to be able to log the output and have pretty options to pass to the pretty printer. These changes would mostly happen in Stack.Types.StackT.

@luigy
Copy link
Contributor

@luigy luigy commented Mar 25, 2016

Wut?! No reactions 😞

I'm pumped for this!

Unless the point got a bit blurred out without screenshots; I feel a bit lonely in haskellandia

@mgsloan
Copy link
Contributor Author

@mgsloan mgsloan commented Mar 28, 2016

I imagine that the lack of responses is more representative of there not being more info to add / not wanting to paint the bikeshed. In other words, people may be tacitly excited. Feel free to implement! :D

@mgsloan
Copy link
Contributor Author

@mgsloan mgsloan commented Jun 4, 2016

I've implemented this!

Check it out: #2236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.