Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Stack.Types to improve build times #2405

Closed
sjakobi opened this issue Jul 22, 2016 · 1 comment
Closed

Delete Stack.Types to improve build times #2405

sjakobi opened this issue Jul 22, 2016 · 1 comment

Comments

@sjakobi
Copy link
Member

@sjakobi sjakobi commented Jul 22, 2016

(Split off from #2334)

Modules would then only depend on the Stack.Types.* modules that they actually need and e.g. Stack.Clean wouldn't have to be recompiled after a change in Stack.Types.Nix.

@Blaisorblade
Copy link
Collaborator

@Blaisorblade Blaisorblade commented Aug 4, 2016

Done for the library, doing it for tests.
According to the PVP, this would forces a version bump to 1.2. Should I readd Stack.Types in or bump the version?

In my last change related to #2334 (0628ff1), I left reexports in to keep the same API and didn't wonder about the PVP.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants