Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--extra-lib-dirs should accept relative paths #2830

Closed
YPares opened this issue Dec 6, 2016 · 3 comments
Closed

--extra-lib-dirs should accept relative paths #2830

YPares opened this issue Dec 6, 2016 · 3 comments

Comments

@YPares
Copy link
Collaborator

@YPares YPares commented Dec 6, 2016

What is the rationale behind forbidding relative paths in the stack.yaml for extra-lib-dirs?
I often need to add a path to a local C lib, and that's not convenient to have to build it via:
stack build --extra-lib-dirs $PWD/my/path

@decentral1se
Copy link
Member

@decentral1se decentral1se commented Dec 30, 2016

679e3ed looks relevant. /cc @sjakobi.

@sjakobi
Copy link
Member

@sjakobi sjakobi commented Jan 2, 2017

679e3ed looks relevant. /cc @sjakobi.

Right, that probably wasn't a good idea. I think it would be nice to have something stronger than a FilePath in the option parser, and working with Path Abs Dir internally is also desirable, but of course that shouldn't come at the cost of user convenience.

@mgsloan mgsloan modified the milestones: shoud, P2: Should Jan 31, 2017
mgsloan added a commit that referenced this issue Mar 19, 2017
mgsloan added a commit that referenced this issue Mar 19, 2017
@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Mar 19, 2017

Implemented!

This was a bit tricky, because we want these paths to be relative to the config file. Similarly, for CLI args it is relative to current work dir. Now that this info is plumbed through, it will be straightforward to add support for relative paths elsewhere in configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.