Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reconfiguring if $PATH changes #3138

Closed
ndmitchell opened this issue Apr 24, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@ndmitchell
Copy link
Contributor

commented Apr 24, 2017

As per haskell/cabal#2015, it seems Cabal caches the $PATH when running configure and reuses it later. As a result, if a package needs a particular program on $PATH at compile time, a user who modifies their $PATH after a failure will continue to remain in a failure state until running a stack clean. Perhaps the $PATH should be considered an input dependency of configure steps?

@mgsloan mgsloan added the type: bug label Jun 6, 2017

@mgsloan

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2017

Good to know! Yes, I think it makes sense to do a reconfigure. The alternative would be to just make this a warning, but that could easily be ignored. Marking as P1 since it has to do with build determinism

@mgsloan mgsloan added this to the P1: Must milestone Jun 6, 2017

@mgsloan

This comment has been minimized.

Copy link
Collaborator

commented Dec 23, 2017

Fixing this will probably invalidate previous configure cache info, so ideally would be batched with any other pending changes to it. Would be possible to have support for reading the old cache version.

snoyberg added a commit that referenced this issue Apr 15, 2019

@snoyberg

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

See #4740

@snoyberg snoyberg closed this in 8355d8c Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.