Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: add hpack command-line option #3179

Closed
scott-fleischman opened this issue May 19, 2017 · 3 comments
Closed

New feature: add hpack command-line option #3179

scott-fleischman opened this issue May 19, 2017 · 3 comments

Comments

@scott-fleischman
Copy link
Contributor

@scott-fleischman scott-fleischman commented May 19, 2017

Proposal: allow one to give a path to an hpack executable rather than using the hack bundled with stack.

Suggestion: include a command line option such as --hpack=<PATH_TO_HPACK>

Use case: we ran into a couple issues with hpack, one of which is fixed on hpack/master and another which is fixed in a PR that is not yet merged. That means we have to wait for both hpack to accept the PR change, as well as wait for the next stack release that bundles those hpack changes. That is a double delay for release cycles. Allowing a custom hpack gives us the freedom to change hpack for our custom needs now and not have to wait for them to be released (which could be months away).

I may look into code changes according to this proposal. I am opening this issue to get feedback on the idea, as well as to double check that I didn't miss an existing option or workaround for this.

Thank you for your consideration!

@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Aug 6, 2017

Makes sense! A PR for this would be appreciated indeed. For consistency I think --with-hpack=<PATH> would be best.

@scott-fleischman
Copy link
Contributor Author

@scott-fleischman scott-fleischman commented Sep 19, 2017

@mgsloan I created a PR here, using --with-hpack as you suggested. #3443

@decentral1se
Copy link
Member

@decentral1se decentral1se commented Sep 19, 2017

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.