New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC installation doesn't work from root folder #3188

Closed
varosi opened this Issue May 26, 2017 · 9 comments

Comments

Projects
None yet
3 participants
@varosi

varosi commented May 26, 2017

General summary/comments (optional)

Steps to reproduce

For example:

  1. Put in the root of some drive (D:) ghc archive
  2. Copy yaml file:
sevenzexe-info:
    url: "https://github.com/fpco/minghc/blob/master/bin/7z.exe?raw=true"
    content-length: 73728
    sha1: 187dff8a3327da87050f678579816e5bae40c632
sevenzdll-info:
    url: "https://github.com/fpco/minghc/blob/master/bin/7z.dll?raw=true"
    content-length: 447488
    sha1: 168a288d4456f0473f66e86a2d6fec4eb6f4b993
msys2:
    windows64:
        version: "20150512"
        url: "https://github.com/fpco/minghc/releases/download/2015-05-14/msys2-base-x86_64-20150512.tar.xz"
        content-length: 33451040
        sha1: 88fa66ac2a18715a542e0768b1af9b2f6e3680b2
ghc:
    windows64-integersimple:
        8.0.2:
            url: "D:/ghc-8.0.2-x86_64-unknown-mingw32-integer-simple.tar.xz"
  1. Run 'stack setup --stack-setup-yaml stack-setup-2.yaml --reinstall --ghc-variant integersimple'

Expected

To work as it is working if GHC archive is moved into a folder D:\ttt\

Stack version

stack --version
Version 1.4.1, Git revision ea10057da1b1a49d937e7bcb6f997360bec1f863 (4765 commits) x86_64 hpack-0.17.0
@lwm

This comment has been minimized.

Member

lwm commented May 29, 2017

Hi @varosi, what is the error you are seeing?

I dug around and saw that it should be fine with absolute paths.

@varosi

This comment has been minimized.

varosi commented May 30, 2017

7-Zip 9.20  Copyright (c) 1999-2010 Igor Pavlov  2010-11-18

Processing archive: D:\ghc-8.0.2-x86_64-unknown-mingw32-integer-simple.tar.xz


Error: Can not create output directory D:\\


System error:
The filename, directory name, or volume label syntax is incorrect.

Problem while decompressing D:\ghc-8.0.2-x86_64-unknown-mingw32-integer-simple.tar.xz
@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented Jun 11, 2017

Looks to me like a bug in 7zip, or perhaps it expects the -o argument to be different. Not sure if stack is passing in D: or D:\.

I've pushed a potential fix - #3212 - please let me know if it works.

@varosi

This comment has been minimized.

varosi commented Jun 12, 2017

I think that the real problem is that it tries to create root folder in D:\ which will not work. See the error message

Error: Can not create output directory D:\

I don't know why it tries to do that.

@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented Jul 18, 2017

@varosi Sorry for the delay! Yes, that is a 7zip error message - https://stackoverflow.com/questions/43039683/cannot-create-output-directory-error-7zip

@varosi

This comment has been minimized.

varosi commented Jul 18, 2017

No problem!

@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented Aug 7, 2017

@varosi I haven't merged #3212 yet, does it fix the problem?

@varosi

This comment has been minimized.

varosi commented Sep 19, 2017

@mgsloan It works with your changes!

mgsloan added a commit that referenced this issue Sep 20, 2017

@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented Sep 20, 2017

Great, thanks for the confirmation!

@mgsloan mgsloan closed this Sep 20, 2017

mgsloan added a commit that referenced this issue Sep 23, 2017

Merge pull request #3212 from commercialhaskell/7zip-temp-dir
When extracting local GHC from tarball on windows, use temp dir #3188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment