Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent --file-watch from watching test suites #3483

Closed
JoeMShanahan opened this issue Oct 10, 2017 · 3 comments
Closed

Prevent --file-watch from watching test suites #3483

JoeMShanahan opened this issue Oct 10, 2017 · 3 comments

Comments

@JoeMShanahan
Copy link

@JoeMShanahan JoeMShanahan commented Oct 10, 2017

How appropriate would it be to allow a new argument which prevents stack from triggering a rebuild when a test suite changes?

During development of a web app using yesod, we're in the situation where I'm running the server with yesod devel (which uses stack ... --file-watch underneath).

Our selenium test suite is attached to the server devel is running. I'm altering some selenium tests which I have loaded with GHCi. When I change the selenium tests, stack notices, which signals to devel that a rebuild is required even though it's not! This really just slows down development.

I propose something like stack build --file-watch --no-watch-tests . What do you think?

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Oct 17, 2017

It may even be reasonable to have that behavior automatically implied based on which components are being built. I don't see a downside to such a change.

@JonnyRa
Copy link

@JonnyRa JonnyRa commented Dec 11, 2017

I was about to log an issue for this but looking at the linked issue it seems to be fixed in 1.6.

I've updated and just tested on my setup and I'm not seeing changes to the tests retriggering builds when they shouldn't now. Woohoo!

Can probably be closed as fixed now?

Nice one!

Cheers

Jonny

@decentral1se
Copy link
Member

@decentral1se decentral1se commented Dec 11, 2017

Thanks @JonnyRa, will close this off!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants