Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify when test suites complete #3552

Closed
tswelsh opened this issue Nov 5, 2017 · 5 comments
Closed

Notify when test suites complete #3552

tswelsh opened this issue Nov 5, 2017 · 5 comments
Assignees
Milestone

Comments

@tswelsh
Copy link
Contributor

@tswelsh tswelsh commented Nov 5, 2017

Sort of similar to #3508. We have a project with many packages and test suites, some of which are very quick unit tests and some of which are long integration tests. When doing a full build +test (especially for newcomers to the project, the natural thing is to do something like stack build --test after getting the repository), the whole thing just looks like it's hanging when it's running the tests. In reality, nearly all tests have completed almost immediately but there are some long ones which don't. So we see e.g.

> stack test
long-tests-0.1.0.0: configure (test)
short-tests-0.1.0.0: configure (test)
long-tests-0.1.0.0: build (test)
long-tests-0.1.0.0: test (suite: long-test-suite)
short-tests-0.1.0.0: build (test)
short-tests-0.1.0.0: test (suite: short-test-suite)

with no indication of which one is hanging. A notification of a test suite completing would help to diagnose this. The situation is a bit better with just builds, but the copy/register line indicates when a particular build is finished.

I can submit a pull request if you think this is an appropriate change, looks simple enough - just adding another call to announce in Stack.Build.Execute.singleTest.

@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Nov 6, 2017

Having trouble easily digging out the issue, but I think somewhere there is a proposal to have the last line of the output be a summary of "Here are the things stack is working on right now". Then, the lines that actually end up permanently in the output would be indications that something has finished, rather than indications that something has started.

@decentral1se
Copy link
Member

@decentral1se decentral1se commented Nov 6, 2017

I can submit a pull request if you think this is an appropriate change, looks simple enough

I'd definitely like to see what you come up with!

@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Nov 6, 2017

Indeed, a PR is appreciated! It doesn't need to be the full blown "use a sticky log to show what's currently being worked on" that can come later :)

@tswelsh tswelsh mentioned this issue Nov 7, 2017
2 of 2 tasks complete
@tswelsh
Copy link
Contributor Author

@tswelsh tswelsh commented Nov 7, 2017

PR made. I had a poke around for the issue that was mentioned by @mgsloan but couldn't find it either, so I just did the simplest thing possible (it does look a bit ad hoc, but solves my original issue at least).

@decentral1se
Copy link
Member

@decentral1se decentral1se commented Nov 7, 2017

Done in #3552 (I assume it's enough)! Nice one @tswelsh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.