Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valid-wanted is a confusing option name #386

Closed
gregwebs opened this issue Jun 23, 2015 · 6 comments
Closed

valid-wanted is a confusing option name #386

gregwebs opened this issue Jun 23, 2015 · 6 comments
Milestone

Comments

@gregwebs
Copy link
Contributor

@gregwebs gregwebs commented Jun 23, 2015

Its behavior also isn't documented in the stack.yaml wiki page.

I think it would be better to name the option after the difference it makes in stack's behavior

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Jun 23, 2015

Any suggestions?

On Tue, Jun 23, 2015, 10:21 PM Greg Weber notifications@github.com wrote:

Its behavior also isn't documented in the stack.yaml wiki page.

I think it would be better to name the option after the difference it
makes in stack's behavior


Reply to this email directly or view it on GitHub
#386.

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Jun 23, 2015

Oh, I think I've got it. The flag should just be dependency. If set to true, it behaves just like an extra-dep.

@gregwebs
Copy link
Contributor Author

@gregwebs gregwebs commented Jun 23, 2015

yes, dependency (or even extra-dep) would be much better

@snoyberg snoyberg added this to the 0.2.0.0 milestone Jun 24, 2015
@gregwebs
Copy link
Contributor Author

@gregwebs gregwebs commented Jun 24, 2015

Thanks!

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Jun 24, 2015

Thanks for pointing out how bad the name was, it was one of those things that just happened, and we have to fix those problems early :)

@snoyberg snoyberg closed this Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.