New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--file-watch is watching test suites again #4001

Closed
tswelsh opened this Issue May 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@tswelsh
Contributor

tswelsh commented May 2, 2018

This is a regression, the original issue was #3483. At a guess it is due to commit b008a33, which looks like it now uses all package compononents in getPackageFilesForTargets instead of lib + other targets components. Probably an easy fix to make it lib + sublibs + other targets (I don't know anything about sublibs, but presumably they can't be targets and should always be taken into account?). A test would have picked this up, that's on me as I fixed the original issue without adding a test.

$ stack --version
Version 1.7.1, Git revision 681c800873816c022739ca7ed14755e85a579565 (5807 commits) x86_64 hpack-0.28.2

Method of installation

Official binary, downloaded from stackage.org or fpcomplete's package repository

@tswelsh tswelsh referenced this issue May 2, 2018

Merged

4001 excess recompilation #4003

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment