New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 8.4 in addDependentFile for 1.9.3 #4369

Closed
ygale opened this Issue Oct 23, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@ygale
Copy link

ygale commented Oct 23, 2018

The fix for yesodweb/yesod#1551 in aae15e3 did not make it into stack 1.9.1. From what I see in stable, it's currently not even scheduled to make it into stack 1.9.3.

This GHC 8.4 incompatibility is a show-stopper for our front-end team. All our front-end devs are forced to use stack built from git master in a stable production environment, which is not healthy.

Is there a possibility of including this small but critical patch in stack 1.9.3? Thanks!

cc: @bermanjosh

@ygale

This comment has been minimized.

Copy link

ygale commented Oct 23, 2018

Update: Instead of using master, we now forked stack and manually applied @snoyberg 's 3-line fix to the v1.9.1 tag,

But still, the importance to effort ratio seems really high here. It would still be nice if this could make it into 1.9.3.

@borsboom

This comment has been minimized.

Copy link
Contributor

borsboom commented Oct 24, 2018

@snoyberg Any objection to cherry-picking this fix into the stable branch so it gets into the next minor release?

@snoyberg

This comment has been minimized.

Copy link
Contributor

snoyberg commented Oct 24, 2018

No objection.

@ygale

This comment has been minimized.

Copy link

ygale commented Oct 24, 2018

Hmm. Unfortunately, it appears that this fix does not actually resolve yesodweb/yesod#1551.

@ygale

This comment has been minimized.

Copy link

ygale commented Oct 25, 2018

It actually does resolve it. @tolysz pointed out that you also need shakespeare >= 2.0.19.

Thanks for doing this!

@ygale ygale closed this Oct 25, 2018

@ygale

This comment has been minimized.

Copy link

ygale commented Dec 30, 2018

Verified that this is working in the now-released stack 1.9.3. Thanks stack team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment