New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Code ?) improvement: always use verified downloads #4524

Open
qrilka opened this Issue Jan 21, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@qrilka
Copy link
Contributor

qrilka commented Jan 21, 2019

While working on #4515 it was found that Stack.New uses download and not verifiedDownload and the main difference between those is that download doesn't tack download progress and thus doesn't check download length as verifiedDownload could (with correct callback specified as progressSink parameter). Also it looks that redownload doesn't include verifications from verifiedDownload - it makes sense to make any downloads properly verified.

@mihaimaruseac

This comment has been minimized.

Copy link
Contributor

mihaimaruseac commented Jan 21, 2019

I agree with these points, even more so from a security point of view. Not checking download length can result in malicious files being transferred instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment