Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCUSS: Make --interleaved-output the default #4702

Closed
snoyberg opened this issue Apr 5, 2019 · 4 comments
Closed

DISCUSS: Make --interleaved-output the default #4702

snoyberg opened this issue Apr 5, 2019 · 4 comments
Milestone

Comments

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Apr 5, 2019

A few different reasons:

  1. People have been reporting issues about "frozen" compiles, when in fact it's just very large dependencies that take a long time to build. This output will make it clear that work is happening, just slowly.
  2. I've had CI timeouts in the past due to lack of output for 10 minutes. Basically, same as 1, but impatient machines instead of impatient humans
  3. It can be informative to see the output as it happens

Downsides:

  1. Subjectively more confusing
  2. Arguably people don't want to see the individual modules compiling for each dependency

CC @nh2

@snoyberg snoyberg added this to the P1: Must milestone Apr 5, 2019
@Wildsoft
Copy link

@Wildsoft Wildsoft commented Apr 5, 2019

Maybe indicate some progress in some other way to avoid confusing output

@NorfairKing
Copy link
Contributor

@NorfairKing NorfairKing commented Apr 5, 2019

I'd like --interleaved-output for local packages but not for dependencies, by default.
Or that --test implies --interleaved-output if there are multiple packages.

@snoyberg
Copy link
Contributor Author

@snoyberg snoyberg commented Apr 7, 2019

Maybe indicate some progress in some other way to avoid confusing output

Two problems with this:

  1. We'd need to know what "some other way" is. In other words: can you be a bit more specific?
  2. It doesn't exist yet, so would have to be implemented

I'd like --interleaved-output for local packages but not for dependencies, by default.

I get the motivation here. However, it wouldn't address my "frozen compiles" concern above. Not eliminating the possibility, just pointing out a limitation.

snoyberg added a commit that referenced this issue Apr 10, 2019
@snoyberg
Copy link
Contributor Author

@snoyberg snoyberg commented Apr 10, 2019

We can continue to refine the behavior up until the next release, but I've opened up a PR to change the default. This may also flush out some additional problems during testing. #4718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants