New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open-source scripts that build docker images #624

Closed
k-bx opened this Issue Jul 17, 2015 · 8 comments

Comments

Projects
None yet
6 participants
@k-bx
Contributor

k-bx commented Jul 17, 2015

Please, open-source (or point me to) your work on building docker images with full stack packages built inside, so that any person could reproduce and/or customize it.

@borsboom

This comment has been minimized.

Contributor

borsboom commented Jul 21, 2015

We're planning to open this, but the current tool contains some proprietary information and needs refactoring to make it possible to extract that and release the non-proprietary parts as open source.

@borsboom borsboom added this to the 0.3.0.0 milestone Jul 21, 2015

@borsboom borsboom self-assigned this Jul 21, 2015

@k-bx

This comment has been minimized.

Contributor

k-bx commented Jul 21, 2015

@manny-fp thanks, good to know. We decided to search for less hardcode (in terms of infrastructure-change) ways for now, but I'll be watching this.

@PierreR

This comment has been minimized.

PierreR commented Sep 6, 2015

👍
I need a run minimal image alike stack-run but with ruby 2.x. I was hoping to get some information from the Dockerfile for stack-run but it is not available. I know it should be possible to install an extra ruby on the base image but I would prefer to have something as minimal as possible with a single ruby version (that rules out phusion as the base image).

If I understand it correctly, I will need to copy the binary executable for stack. I don't want ghc in the base run image.

@borsboom

This comment has been minimized.

Contributor

borsboom commented Nov 21, 2015

Since the Docker integration can now use any image, custom images no longer need depend on the images FP Complete generates (see https://github.com/commercialhaskell/stack/blob/master/doc/docker_integration.md#custom-images). Therefore, reducing the priority of this issue.

@igrep

This comment has been minimized.

Contributor

igrep commented May 8, 2016

You mean, the actual docker images are built after adding some changes (by the proprietary tools) to https://github.com/commercialhaskell/stack/blob/a562702b3bcda71bc73663320a38e7cb937d1163/etc/docker/stack-base/Dockerfile ?

@kanishka-azimi

This comment has been minimized.

kanishka-azimi commented Jan 12, 2017

How close is the linked dockerfile to the lts's?

@borsboom

This comment has been minimized.

Contributor

borsboom commented Jan 17, 2017

@kanishka-azimi: that Dockerfile is not related at all. I don't think that Dockerfile is actually used for anything and I'm going to remove it to avoid confusion.

BTW I'm planning to open this up in the very near future. We're moving away from the current shake- and propellor- based process to build the images to a simplified one without any of the proprietary stuff, so it will just be a simple Dockerfile.

@borsboom borsboom closed this in 9a1b497 Feb 13, 2017

@borsboom

This comment has been minimized.

Contributor

borsboom commented Feb 13, 2017

The new scripts for LTS >= 8.0 are here: https://github.com/commercialhaskell/stack/tree/master/etc/dockerfiles/stack-build

This is vastly simplified from the proprietary scripts we were using for LTS <= 7.x. Now we're only building the stack-build images (no more stack-run and stack-full images), and a bunch of stuff is being left out as Stack itself has gotten the functionality built into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment